Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1337)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ash/common/wm_window_property.h

Issue 2357143004: mash: Support ShelfWindowWatcher via ShelfItem properties. (Closed)
Patch Set: Address comments. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/common/wm_window.h ('k') | ash/mus/bridge/wm_window_mus.h » ('j') | chrome/browser/ui/ash/launcher/browser_status_monitor.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/wm_window_property.h
diff --git a/ash/common/wm_window_property.h b/ash/common/wm_window_property.h
index 57506bea8f22fb25c306cc6ea6690ad9718085e8..17c1d85a69388a50d7a3b5ed5c236112d74c4f8e 100644
--- a/ash/common/wm_window_property.h
+++ b/ash/common/wm_window_property.h
@@ -18,10 +18,13 @@ enum class WmWindowProperty {
MODAL_TYPE,
// Type int.
+ SHELF_ICON_ID,
James Cook 2016/09/29 02:49:46 I would also rename this SHELF_ICON_RESOURCE_ID to
msw 2016/09/29 06:23:36 Done. Clarity is more important than brevity :-)
+
+ // Type int.
SHELF_ID,
- // Type ShelfItemDetails.
- SHELF_ITEM_DETAILS,
+ // Type int, but cast to ShelfItemType.
+ SHELF_ITEM_TYPE,
// Type bool.
SNAP_CHILDREN_TO_PIXEL_BOUNDARY,
« no previous file with comments | « ash/common/wm_window.h ('k') | ash/mus/bridge/wm_window_mus.h » ('j') | chrome/browser/ui/ash/launcher/browser_status_monitor.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698