Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: ash/common/wm_window_property.h

Issue 2357143004: mash: Support ShelfWindowWatcher via ShelfItem properties. (Closed)
Patch Set: Address comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ASH_COMMON_WM_WINDOW_PROPERTY_H_ 5 #ifndef ASH_COMMON_WM_WINDOW_PROPERTY_H_
6 #define ASH_COMMON_WM_WINDOW_PROPERTY_H_ 6 #define ASH_COMMON_WM_WINDOW_PROPERTY_H_
7 7
8 namespace ash { 8 namespace ash {
9 9
10 enum class WmWindowProperty { 10 enum class WmWindowProperty {
11 // Type bool. 11 // Type bool.
12 ALWAYS_ON_TOP, 12 ALWAYS_ON_TOP,
13 13
14 // Type bool. See aura::client:kExcludeFromMruKey for details. 14 // Type bool. See aura::client:kExcludeFromMruKey for details.
15 EXCLUDE_FROM_MRU, 15 EXCLUDE_FROM_MRU,
16 16
17 // Type int, but cast to ui::ModalType. 17 // Type int, but cast to ui::ModalType.
18 MODAL_TYPE, 18 MODAL_TYPE,
19 19
20 // Type int. 20 // Type int.
21 SHELF_ICON_ID,
James Cook 2016/09/29 02:49:46 I would also rename this SHELF_ICON_RESOURCE_ID to
msw 2016/09/29 06:23:36 Done. Clarity is more important than brevity :-)
22
23 // Type int.
21 SHELF_ID, 24 SHELF_ID,
22 25
23 // Type ShelfItemDetails. 26 // Type int, but cast to ShelfItemType.
24 SHELF_ITEM_DETAILS, 27 SHELF_ITEM_TYPE,
25 28
26 // Type bool. 29 // Type bool.
27 SNAP_CHILDREN_TO_PIXEL_BOUNDARY, 30 SNAP_CHILDREN_TO_PIXEL_BOUNDARY,
28 31
29 // Type SkColor. See aura::client::kTopViewColor for details. 32 // Type SkColor. See aura::client::kTopViewColor for details.
30 TOP_VIEW_COLOR, 33 TOP_VIEW_COLOR,
31 34
32 // Type int. See aura::client::kTopViewInset for details. 35 // Type int. See aura::client::kTopViewInset for details.
33 TOP_VIEW_INSET, 36 TOP_VIEW_INSET,
34 }; 37 };
35 38
36 } // namespace ash 39 } // namespace ash
37 40
38 #endif // ASH_COMMON_WM_WINDOW_PROPERTY_H_ 41 #endif // ASH_COMMON_WM_WINDOW_PROPERTY_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698