Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: ash/common/wm_window.h

Issue 2357143004: mash: Support ShelfWindowWatcher via ShelfItem properties. (Closed)
Patch Set: Set Settings WmWindow title with a WmWindowObserver. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/wm_window.h
diff --git a/ash/common/wm_window.h b/ash/common/wm_window.h
index 30dc6ab359bac68fb92bcdb2acca1fe7aed16186..0dbf4dbd5ba6b101823be0cf591499799e85ec7c 100644
--- a/ash/common/wm_window.h
+++ b/ash/common/wm_window.h
@@ -41,7 +41,6 @@ class Widget;
namespace ash {
class ImmersiveFullscreenController;
-struct ShelfItemDetails;
class WmLayoutManager;
class WmRootWindowController;
class WmShell;
@@ -81,6 +80,7 @@ class ASH_EXPORT WmWindow {
virtual void SetName(const char* name) = 0;
virtual std::string GetName() const = 0;
+ virtual void SetTitle(const base::string16& title) = 0;
virtual base::string16 GetTitle() const = 0;
// See shell_window_ids.h for list of known ids.
@@ -133,11 +133,6 @@ class ASH_EXPORT WmWindow {
virtual int GetIntProperty(WmWindowProperty key) = 0;
virtual void SetIntProperty(WmWindowProperty key, int value) = 0;
- // Returns null if there are no details.
- virtual ShelfItemDetails* GetShelfItemDetails() = 0;
- virtual void SetShelfItemDetails(const ShelfItemDetails& details) = 0;
- virtual void ClearShelfItemDetails() = 0;
-
wm::WindowState* GetWindowState() {
return const_cast<wm::WindowState*>(
const_cast<const WmWindow*>(this)->GetWindowState());

Powered by Google App Engine
This is Rietveld 408576698