src/IceTargetLoweringMIPS32.cpp - Issue 2357143002: [SubZero] Fix floating-point comparison for MIPS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTargetLoweringMIPS32.cpp

Issue 2357143002: [SubZero] Fix floating-point comparison for MIPS (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Addressed review comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceTargetLoweringMIPS32.cpp

diff --git a/src/IceTargetLoweringMIPS32.cpp b/src/IceTargetLoweringMIPS32.cpp

index 6d6c6b9316f43f8e48f4e759d7493ea7a7eea595..e7417e4422f59b2e9fb7709a193421d33fc5e343 100644

--- a/src/IceTargetLoweringMIPS32.cpp

+++ b/src/IceTargetLoweringMIPS32.cpp

@@ -3337,9 +3337,8 @@ void TargetMIPS32::prelowerPhis() {

void TargetMIPS32::postLower() {

if (Func->getOptLevel() == Opt_m1)

return;

- // TODO(rkotler): Find two-address non-SSA instructions where Dest==Src0,

- // and set the IsDestRedefined flag to keep liveness analysis consistent.

- UnimplementedError(getFlags());

+ markRedefinitions();

+ Context.availabilityUpdate();

}

void TargetMIPS32::makeRandomRegisterPermutation(

« no previous file with comments | « src/IceTargetLoweringMIPS32.h ('k') | no next file » | no next file with comments »