[SubZero] Fix floating-point comparison for MIPS

[SubZero] Fix floating-point comparison for MIPS

The patch fixes code generation and encoding of floating-point comparison.
All floating-point comparison related test in test_fcmp cross test pass (after removing vector related tests):
TotalTests=123904 Passes=123904 Failures=0

R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=d895447ba9131c9d8cb3b10080feeed3beef6be9

[jaydeep.patil, 2016-09-21 11:35:56]

Description was changed from

==========
[SubZero] Fix floating-point comparison for MIPS

The patch fixes code generation and encoding of floating-point comparison.
All floating-point comparison related test in test_fcmp cross test pass (after
removing vector related tests):
TotalTests=123904 Passes=123904 Failures=0
==========

to

==========
[SubZero] Fix floating-point comparison for MIPS

The patch fixes code generation and encoding of floating-point comparison.
All floating-point comparison related test in test_fcmp cross test pass (after
removing vector related tests):
TotalTests=123904 Passes=123904 Failures=0
==========

[jaydeep.patil, 2016-09-21 11:35:56]

jaydeep.patil@imgtec.com changed reviewers:
+ eholk@chromium.org, jpp@chromium.org, kschimpf@google.com,
sagar.thakur@imgtec.com, srdjan.obucina@imgtec.com, stichnot@chromium.org

[Jim Stichnoth, 2016-09-21 13:24:29]

lgtm

[Jim Stichnoth, 2016-09-21 13:24:44]

Description was changed from

==========
[SubZero] Fix floating-point comparison for MIPS

The patch fixes code generation and encoding of floating-point comparison.
All floating-point comparison related test in test_fcmp cross test pass (after
removing vector related tests):
TotalTests=123904 Passes=123904 Failures=0
==========

to

==========
[SubZero] Fix floating-point comparison for MIPS

The patch fixes code generation and encoding of floating-point comparison.
All floating-point comparison related test in test_fcmp cross test pass (after
removing vector related tests):
TotalTests=123904 Passes=123904 Failures=0

R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2016-09-21 13:24:45]

Committed patchset #1 (id:1) manually as
d895447ba9131c9d8cb3b10080feeed3beef6be9 (presubmit successful).

[Jim Stichnoth, 2016-09-21 17:07:10]

https://codereview.chromium.org/2357143002/diff/1/src/IceTargetLoweringMIPS32.h
File src/IceTargetLoweringMIPS32.h (right):

https://codereview.chromium.org/2357143002/diff/1/src/IceTargetLoweringMIPS32...
src/IceTargetLoweringMIPS32.h:361: Instr->setDestRedefined();
Sorry, I missed this the first time.

You should be able to avoid calling setDestRedefined() if you modify
TargetMIPS32::postLower() to call TargetLowering::markRedefinitions() in the -O2
case.

[jaydeep.patil, 2016-09-22 03:07:58]

https://codereview.chromium.org/2357143002/diff/1/src/IceTargetLoweringMIPS32.h
File src/IceTargetLoweringMIPS32.h (right):

https://codereview.chromium.org/2357143002/diff/1/src/IceTargetLoweringMIPS32...
src/IceTargetLoweringMIPS32.h:361: Instr->setDestRedefined();
On 2016/09/21 17:07:10, stichnot wrote:
> Sorry, I missed this the first time.
> 
> You should be able to avoid calling setDestRedefined() if you modify
> TargetMIPS32::postLower() to call TargetLowering::markRedefinitions() in the
-O2
> case.

Done.