Issue 235713003: [CSS Grid Layout] Use gridRowCount() and gridColumnCount() when possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 235713003: [CSS Grid Layout] Use gridRowCount() and gridColumnCount() when possible (Closed)

Created:
6 years, 8 months ago by Manuel Rego

Modified:
6 years, 7 months ago

Reviewers:
leviw_travelin_and_unemployed, eseidel, esprehn, Julien - ping for review

CC:
blink-reviews, jfernandez, zoltan1, svillar, bemjb+rendering_chromium.org, Manuel Rego, leviw+renderwatch, eae+blinkwatch, jchaffraix+rendering, dsinclair, pdr., rune+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

[CSS Grid Layout] Use gridRowCount() and gridColumnCount() when possible Use gridRowCount() and gridColumnCount() instead of m_grid.size() and m_grid[0].size() to make the code more descriptive and easier to understand. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172914

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
	M	Source/core/rendering/RenderGrid.cpp	View		3 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rego@igalia.com/235713003/1

6 years, 7 months ago (2014-04-29 21:36:47 UTC) #3

Message was sent while issue was closed.

Change committed as 172914

Expand Messages | Collapse Messages