chrome/browser/chromeos/arc/arc_process_service.cc - Issue 2357053002: Always use arc::InstanceHolder<T>::GetInstanceForMethod

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/arc/arc_process_service.cc

Issue 2357053002: Always use arc::InstanceHolder<T>::GetInstanceForMethod (Closed)

Patch Set: rebased to catch up tot Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/arc/arc_process_service.cc

diff --git a/chrome/browser/chromeos/arc/arc_process_service.cc b/chrome/browser/chromeos/arc/arc_process_service.cc

index ab08b4771c44cb29115edd4c233fca591942f788..c08d34ede92313249e46f94e7354b4d5bdc02239 100644

--- a/chrome/browser/chromeos/arc/arc_process_service.cc

+++ b/chrome/browser/chromeos/arc/arc_process_service.cc

@@ -245,7 +245,8 @@ bool ArcProcessService::RequestAppProcessList(

DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

arc::mojom::ProcessInstance* process_instance =

- arc_bridge_service()->process()->instance();

+ arc_bridge_service()->process()->GetInstanceForMethod(

+ "RequestProcessList");

if (!process_instance) {

return false;

}