Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/chromeos/arc/arc_print_service.cc

Issue 2357053002: Always use arc::InstanceHolder<T>::GetInstanceForMethod (Closed)
Patch Set: rebased to catch up tot Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/chromeos/arc/arc_navigation_throttle.cc ('K') | « chrome/browser/chromeos/arc/arc_policy_bridge.cc ('k') | chrome/browser/chromeos/arc/arc_process_service.cc » ('j') | chrome/browser/memory/tab_manager_delegate_chromeos.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/arc/arc_print_service.cc
diff --git a/chrome/browser/chromeos/arc/arc_print_service.cc b/chrome/browser/chromeos/arc/arc_print_service.cc
index 28de889953839e35bfa71d53f4c6f3f8dde43fe8..8561d052d6f066e905100a263c5757530a8a78ee 100644
--- a/chrome/browser/chromeos/arc/arc_print_service.cc
+++ b/chrome/browser/chromeos/arc/arc_print_service.cc
@@ -67,12 +67,8 @@ ArcPrintService::~ArcPrintService() {
void ArcPrintService::OnInstanceReady() {
mojom::PrintInstance* print_instance =
- arc_bridge_service()->print()->instance();
- if (!print_instance) {
- LOG(ERROR) << "OnPrintInstanceReady called, but no print instance found";
- return;
- }
-
+ arc_bridge_service()->print()->GetInstanceForMethod("Init");
+ CHECK(print_instance);
print_instance->Init(binding_.CreateInterfacePtrAndBind());
}
« chrome/browser/chromeos/arc/arc_navigation_throttle.cc ('K') | « chrome/browser/chromeos/arc/arc_policy_bridge.cc ('k') | chrome/browser/chromeos/arc/arc_process_service.cc » ('j') | chrome/browser/memory/tab_manager_delegate_chromeos.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698