components/arc/obb_mounter/arc_obb_mounter_bridge.cc - Issue 2357053002: Always use arc::InstanceHolder<T>::GetInstanceForMethod

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/arc/obb_mounter/arc_obb_mounter_bridge.cc

Issue 2357053002: Always use arc::InstanceHolder<T>::GetInstanceForMethod (Closed)

Patch Set: review Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/arc/obb_mounter/arc_obb_mounter_bridge.cc

diff --git a/components/arc/obb_mounter/arc_obb_mounter_bridge.cc b/components/arc/obb_mounter/arc_obb_mounter_bridge.cc

index 04362b7cbf94d21bf0c3e86607150d0b7b05220a..e4daad840d5acf2e63e160256a61b8af719d32ad 100644

--- a/components/arc/obb_mounter/arc_obb_mounter_bridge.cc

+++ b/components/arc/obb_mounter/arc_obb_mounter_bridge.cc

@@ -32,7 +32,9 @@ ArcObbMounterBridge::~ArcObbMounterBridge() {

void ArcObbMounterBridge::OnInstanceReady() {

mojom::ObbMounterInstance* obb_mounter_instance =

- arc_bridge_service()->obb_mounter()->instance();

+ arc_bridge_service()->obb_mounter()->GetInstanceForMethod("Init");

+ if (!obb_mounter_instance)

+ return;

obb_mounter_instance->Init(binding_.CreateInterfacePtrAndBind());

}