components/arc/net/arc_net_host_impl.cc - Issue 2357053002: Always use arc::InstanceHolder<T>::GetInstanceForMethod

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/arc/net/arc_net_host_impl.cc

Issue 2357053002: Always use arc::InstanceHolder<T>::GetInstanceForMethod (Closed)

Patch Set: review Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/arc/net/arc_net_host_impl.cc

diff --git a/components/arc/net/arc_net_host_impl.cc b/components/arc/net/arc_net_host_impl.cc

index 824df9582dce3aacb570a412a10173e443c71c4d..77f631c6e87fb0c6c4edb740678f36596cb3422e 100644

--- a/components/arc/net/arc_net_host_impl.cc

+++ b/components/arc/net/arc_net_host_impl.cc

@@ -309,7 +309,10 @@ void ArcNetHostImpl::OnInstanceReady() {

mojom::NetHostPtr host;

binding_.Bind(GetProxy(&host));

- arc_bridge_service()->net()->instance()->Init(std::move(host));

+ auto* instance = arc_bridge_service()->net()->GetInstanceForMethod("Init");

+ if (!instance)

+ return;

+ instance->Init(std::move(host));

}

void ArcNetHostImpl::GetNetworksDeprecated(