Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Issue 2356973002: Revert of Add work-around to symlink.gni to avoid "not up-to-date" ninja errors (Closed)

Created:
4 years, 3 months ago by Jackie Quinn
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke, agrieve
CC:
chromium-reviews, sdefresne
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add work-around to symlink.gni to avoid "not up-to-date" ninja errors (patchset #1 id:1 of https://codereview.chromium.org/2344243002/ ) Reason for revert: Breaks iOS build with failure: FAILED: gen/linked_src/third_party/objective_c/google_toolbox_for_mac python ../../build/symlink.py --update-target-mtimes -f ../../../../../../third_party/google_toolbox_for_mac/src gen/linked_src/third_party/objective_c/google_toolbox_for_mac Traceback (most recent call last): File "../../build/symlink.py", line 65, in <module> sys.exit(Main(sys.argv)) File "../../build/symlink.py", line 56, in Main os.utime(s, None) OSError: [Errno 2] No such file or directory: '../../../../../../third_party/google_toolbox_for_mac/src' Original issue's description: > Add work-around to symlink.gni to avoid "not up-to-date" ninja errors > > Ninja bug: https://github.com/ninja-build/ninja/issues/1186 > > BUG=646165 > > Committed: https://crrev.com/80f464d5151c3eec102604faf5fa36d9369b64aa > Cr-Commit-Position: refs/heads/master@{#419751} TBR=dpranke@chromium.org,agrieve@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=646165 Committed: https://crrev.com/65f3a42b24088c3a96de9becbe96c4a0094ca843 Cr-Commit-Position: refs/heads/master@{#419871}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M build/symlink.gni View 1 chunk +0 lines, -1 line 0 comments Download
M build/symlink.py View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Jackie Quinn
Created Revert of Add work-around to symlink.gni to avoid "not up-to-date" ninja errors
4 years, 3 months ago (2016-09-20 22:12:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356973002/1
4 years, 3 months ago (2016-09-20 22:12:44 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 22:14:00 UTC) #5
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-20 22:15:23 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/65f3a42b24088c3a96de9becbe96c4a0094ca843 Cr-Commit-Position: refs/heads/master@{#419871}
4 years, 3 months ago (2016-09-20 22:16:37 UTC) #8
agrieve
4 years, 3 months ago (2016-09-21 00:16:47 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2356083003/ by agrieve@chromium.org.

The reason for reverting is: Will update when I've added a try/catch.

Powered by Google App Engine
This is Rietveld 408576698