Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1355)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/symlink.py

Issue 2356973002: Revert of Add work-around to symlink.gni to avoid "not up-to-date" ninja errors (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/symlink.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/symlink.py
diff --git a/build/symlink.py b/build/symlink.py
index 564c0777bd575cd0019e2efcb0dd359f09cb24d0..5a261dcad93e1bddc77b42312f552a12dc8c131f 100755
--- a/build/symlink.py
+++ b/build/symlink.py
@@ -24,7 +24,6 @@
parser = optparse.OptionParser()
parser.add_option('-f', '--force', action='store_true')
parser.add_option('--touch')
- parser.add_option('--update-target-mtimes', action='store_true')
options, args = parser.parse_args(argv[1:])
if len(args) < 2:
@@ -50,10 +49,6 @@
os.symlink(s, t)
else:
raise
- if options.update_target_mtimes:
- # Work-around for ninja bug:
- # https://github.com/ninja-build/ninja/issues/1186
- os.utime(s, None)
if options.touch:
« no previous file with comments | « build/symlink.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698