Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2356943002:
Ship async functions (Closed)
|
Created:
4 years, 3 months ago by Dan Ehrenberg Modified:
4 years, 2 months ago CC:
Michael Hablich, v8-reviews_googlegroups.com, kozy Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionShip async functions
Intent to ship discussion:
https://groups.google.com/forum/#!topic/v8-users/gwpcEIrgIZY
BUG=v8:4483
Committed: https://crrev.com/9f7540a0ec6333e7c71615609fe29274d9b7a4c5
Cr-Commit-Position: refs/heads/master@{#39697}
Patch Set 1 #Patch Set 2 : Rebase #Messages
Total messages: 18 (12 generated)
Description was changed from ========== Ship async functions BUG=v8:4483 ========== to ========== Ship async functions Intent to ship discussion: https://groups.google.com/forum/#!topic/v8-users/gwpcEIrgIZY BUG=v8:4483 ==========
littledan@chromium.org changed reviewers: + adamk@chromium.org, caitp@igalia.com
The CQ bit was checked by littledan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by littledan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by littledan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Ship async functions Intent to ship discussion: https://groups.google.com/forum/#!topic/v8-users/gwpcEIrgIZY BUG=v8:4483 ========== to ========== Ship async functions Intent to ship discussion: https://groups.google.com/forum/#!topic/v8-users/gwpcEIrgIZY BUG=v8:4483 Committed: https://crrev.com/9f7540a0ec6333e7c71615609fe29274d9b7a4c5 Cr-Commit-Position: refs/heads/master@{#39697} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/9f7540a0ec6333e7c71615609fe29274d9b7a4c5 Cr-Commit-Position: refs/heads/master@{#39697}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2364963003/ by adamk@chromium.org. The reason for reverting is: Triggers TSAN errors on Linux64: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/11901. |
