Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2356883002: DevTools: prefer tab-based ids when reporting disovered targets on android. (Closed)

Created:
4 years, 3 months ago by pfeldman
Modified:
4 years, 3 months ago
Reviewers:
dgozman
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: prefer tab-based ids when reporting disovered targets on android. BUG=641390 TBR= follow-up to change in the API. Committed: https://crrev.com/2236ce0a8ac748e16fbf46e8a9c1c97c9061645f Cr-Commit-Position: refs/heads/master@{#419902}

Patch Set 1 #

Patch Set 2 : w/ attach #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/android/devtools_manager_delegate_android.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
pfeldman
4 years, 3 months ago (2016-09-20 19:27:06 UTC) #2
dgozman
lgtm
4 years, 3 months ago (2016-09-20 19:29:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356883002/1
4 years, 3 months ago (2016-09-20 19:32:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/263159)
4 years, 3 months ago (2016-09-20 19:42:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356883002/20001
4 years, 3 months ago (2016-09-20 23:07:34 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-21 00:00:09 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 00:04:01 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2236ce0a8ac748e16fbf46e8a9c1c97c9061645f
Cr-Commit-Position: refs/heads/master@{#419902}

Powered by Google App Engine
This is Rietveld 408576698