Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4407)

Unified Diff: chrome/browser/android/devtools_manager_delegate_android.cc

Issue 2356883002: DevTools: prefer tab-based ids when reporting disovered targets on android. (Closed)
Patch Set: w/ attach Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/devtools_manager_delegate_android.cc
diff --git a/chrome/browser/android/devtools_manager_delegate_android.cc b/chrome/browser/android/devtools_manager_delegate_android.cc
index a9e57a92390edcc2339f669355b25fc324e8232c..c73cc99e726758906f7541669f03d71f1a88fee8 100644
--- a/chrome/browser/android/devtools_manager_delegate_android.cc
+++ b/chrome/browser/android/devtools_manager_delegate_android.cc
@@ -54,6 +54,8 @@ class TabProxyDelegate : public content::DevToolsExternalAgentProxyDelegate,
void Attach(content::DevToolsExternalAgentProxy* proxy) override {
proxy_ = proxy;
MaterializeAgentHost();
+ if (agent_host_)
+ agent_host_->AttachClient(this);
}
void Detach() override {
@@ -170,10 +172,14 @@ DevToolsAgentHost::List GetDescriptors() {
if (!tab)
continue;
+ if (tab->web_contents())
+ tab_web_contents.insert(tab->web_contents());
+
scoped_refptr<DevToolsAgentHost> host =
DevToolsAgentHost::Forward(
base::IntToString(tab->GetAndroidId()),
base::WrapUnique(new TabProxyDelegate(tab)));
+ result.push_back(host);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698