Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: net/quic/core/crypto/quic_crypto_server_config.cc

Issue 2356873002: Extra error logging for missing SCT. Not flag protected (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/crypto/quic_crypto_server_config.cc
diff --git a/net/quic/core/crypto/quic_crypto_server_config.cc b/net/quic/core/crypto/quic_crypto_server_config.cc
index f2db4f53d2681373a2516331feddc2a0c40e1a76..66860e767845e950f2a746a03facbc120505d25d 100644
--- a/net/quic/core/crypto/quic_crypto_server_config.cc
+++ b/net/quic/core/crypto/quic_crypto_server_config.cc
@@ -1325,7 +1325,8 @@ bool QuicCryptoServerConfig::BuildServerConfigUpdateMessage(
out->SetStringPiece(kPROF, signature);
if (params.sct_supported_by_client && enable_serving_sct_) {
if (cert_sct.empty()) {
- DLOG(WARNING) << "SCT is expected but it is empty.";
+ DLOG(WARNING) << "SCT is expected but it is empty. sni: " << params.sni
+ << " server_ip: " << server_ip.ToString();
} else {
out->SetStringPiece(kCertificateSCTTag, cert_sct);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698