Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: net/quic/core/crypto/quic_crypto_server_config.cc

Issue 2356873002: Extra error logging for missing SCT. Not flag protected (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/core/crypto/quic_crypto_server_config.h" 5 #include "net/quic/core/crypto/quic_crypto_server_config.h"
6 6
7 #include <stdlib.h> 7 #include <stdlib.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 #include <memory> 10 #include <memory>
(...skipping 1307 matching lines...) Expand 10 before | Expand all | Expand 10 after
1318 } 1318 }
1319 1319
1320 const string compressed = CompressChain( 1320 const string compressed = CompressChain(
1321 compressed_certs_cache, chain, params.client_common_set_hashes, 1321 compressed_certs_cache, chain, params.client_common_set_hashes,
1322 params.client_cached_cert_hashes, common_cert_sets); 1322 params.client_cached_cert_hashes, common_cert_sets);
1323 1323
1324 out->SetStringPiece(kCertificateTag, compressed); 1324 out->SetStringPiece(kCertificateTag, compressed);
1325 out->SetStringPiece(kPROF, signature); 1325 out->SetStringPiece(kPROF, signature);
1326 if (params.sct_supported_by_client && enable_serving_sct_) { 1326 if (params.sct_supported_by_client && enable_serving_sct_) {
1327 if (cert_sct.empty()) { 1327 if (cert_sct.empty()) {
1328 DLOG(WARNING) << "SCT is expected but it is empty."; 1328 DLOG(WARNING) << "SCT is expected but it is empty. sni: " << params.sni
1329 << " server_ip: " << server_ip.ToString();
1329 } else { 1330 } else {
1330 out->SetStringPiece(kCertificateSCTTag, cert_sct); 1331 out->SetStringPiece(kCertificateSCTTag, cert_sct);
1331 } 1332 }
1332 } 1333 }
1333 return true; 1334 return true;
1334 } 1335 }
1335 1336
1336 void QuicCryptoServerConfig::BuildServerConfigUpdateMessage( 1337 void QuicCryptoServerConfig::BuildServerConfigUpdateMessage(
1337 QuicVersion version, 1338 QuicVersion version,
1338 StringPiece chlo_hash, 1339 StringPiece chlo_hash,
(...skipping 731 matching lines...) Expand 10 before | Expand all | Expand 10 after
2070 priority(0), 2071 priority(0),
2071 source_address_token_boxer(nullptr) {} 2072 source_address_token_boxer(nullptr) {}
2072 2073
2073 QuicCryptoServerConfig::Config::~Config() { 2074 QuicCryptoServerConfig::Config::~Config() {
2074 base::STLDeleteElements(&key_exchanges); 2075 base::STLDeleteElements(&key_exchanges);
2075 } 2076 }
2076 2077
2077 QuicCryptoProof::QuicCryptoProof() {} 2078 QuicCryptoProof::QuicCryptoProof() {}
2078 QuicCryptoProof::~QuicCryptoProof() {} 2079 QuicCryptoProof::~QuicCryptoProof() {}
2079 } // namespace net 2080 } // namespace net
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698