Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2356853002: GN: add skia_enable_gpu (default true) (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
Brian Osman
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: add skia_enable_gpu (default true) This lets us replace the NoGPU bot. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356853002 NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/06c35c0953b4884c18d1f2ce32c4c5045f86fa81

Patch Set 1 #

Patch Set 2 : Take over bot. #

Patch Set 3 : pith #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -36 lines) Patch
M BUILD.gn View 1 2 12 chunks +34 lines, -27 lines 0 comments Download
M infra/bots/recipe_modules/flavor/gn_flavor.py View 1 2 chunks +3 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-x86_64-Debug-NoGPU.json View 1 1 chunk +28 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
mtklein_C
4 years, 3 months ago (2016-09-20 18:44:57 UTC) #3
Brian Osman
lgtm
4 years, 3 months ago (2016-09-20 18:51:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356853002/60001
4 years, 3 months ago (2016-09-20 18:52:11 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/06c35c0953b4884c18d1f2ce32c4c5045f86fa81
4 years, 3 months ago (2016-09-20 19:28:16 UTC) #9
fmalita_google_do_not_use
On 2016/09/20 19:28:16, commit-bot: I haz the power wrote: > Committed patchset #4 (id:60001) as ...
4 years, 3 months ago (2016-09-20 21:40:56 UTC) #10
mtklein
4 years, 3 months ago (2016-09-20 21:49:30 UTC) #11
Message was sent while issue was closed.
On 2016/09/20 21:40:56, fmalita_google_do_not_use wrote:
> On 2016/09/20 19:28:16, commit-bot: I haz the power wrote:
> > Committed patchset #4 (id:60001) as
> >
https://skia.googlesource.com/skia/+/06c35c0953b4884c18d1f2ce32c4c5045f86fa81
> 
> Maybe related?
> 
> https://luci-milo.appspot.com/swarming/task/31624bbca8fa2e10/steps/dm/0/stdout
> 
> WARNING: can not create GPU context for config 'vk'. GM tests will be skipped.
> Skipping config vk: Don't understand 'vk'.
> + >/data/local/tmp/rc 
> + echo 1
> step returned non-zero exit code: 1

Yes, definitely.  It'll be fixed by https://codereview.chromium.org/2352923003/.
 If that doesn't land soon I'll revert and reland them together.

Powered by Google App Engine
This is Rietveld 408576698