Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 2356813003: Attempt to fix nanobench upload (Closed)

Created:
4 years, 3 months ago by borenet2
Modified:
4 years, 3 months ago
Reviewers:
jcgregorio, borenet, hinoka
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Re-apply gsutil change #

Patch Set 3 : Don't gzip locally #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -20 lines) Patch
M infra/bots/recipe_modules/core/resources/upload_bench_results.py View 1 2 1 chunk +5 lines, -12 lines 0 comments Download
M infra/bots/recipes/swarm_housekeeper.py View 1 1 chunk +1 line, -2 lines 0 comments Download
M infra/bots/recipes/swarm_housekeeper.expected/Housekeeper-PerCommit.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_housekeeper.expected/Housekeeper-PerCommit-Trybot.json View 1 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_trigger.py View 1 1 chunk +1 line, -2 lines 0 comments Download
M infra/bots/recipes/swarm_trigger.expected/Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Trybot.json View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
borenet
I think this should work, but let's wait for the trybot.
4 years, 3 months ago (2016-09-20 19:03:53 UTC) #3
jcgregorio
lgtm
4 years, 3 months ago (2016-09-20 19:10:06 UTC) #4
borenet
On 2016/09/20 19:10:06, jcgregorio wrote: > lgtm This looks right, can you double check? https://pantheon.corp.google.com/storage/browser/skia-perf/trybot/nano-json-v1/2016/09/20/19/Perf-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Release-GN-Trybot/0/2356813003/
4 years, 3 months ago (2016-09-20 19:12:38 UTC) #5
borenet
No local gzip at patch set 3
4 years, 3 months ago (2016-09-20 19:57:48 UTC) #7
jcgregorio
lgtm
4 years, 3 months ago (2016-09-20 19:59:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356813003/40001
4 years, 3 months ago (2016-09-20 20:31:26 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 20:32:40 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/c549212cb3fa88c00cb1592dfd508c5aa0349899

Powered by Google App Engine
This is Rietveld 408576698