Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2356783002: skia_enable_android_framework_defines in all code, public and private, optional and required. (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

skia_enable_android_framework_defines in all code, public and private, optional and required. The bug fixed here can be demonstrated by $ ninja -C out pdf -v before and after this CL. Before you won't see the Android defines, afterwards you do. Previously the defines applied only privately to Skia, and only to its non-optional components. TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356783002 Committed: https://skia.googlesource.com/skia/+/cae1be5acc8148fc5cbadd8730ee7994e50a1a47

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M BUILD.gn View 3 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356783002/1
4 years, 3 months ago (2016-09-20 14:41:32 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 15:24:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/cae1be5acc8148fc5cbadd8730ee7994e50a1a47

Powered by Google App Engine
This is Rietveld 408576698