Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: BUILD.gn

Issue 2356783002: skia_enable_android_framework_defines in all code, public and private, optional and required. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 5544593e6ef2d704006acb9265c8fdea194c9fc5..c94f3cf9dfb64d579ad8fef75afc191e1175484a 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -49,6 +49,9 @@ config("skia_public") {
if (is_linux) {
defines += [ "SK_SAMPLES_FOR_X" ]
}
+ if (skia_enable_android_framework_defines) {
+ defines += skia_android_framework_defines
+ }
}
# Skia internal APIs, used by Skia itself and a few test tools.
@@ -224,11 +227,6 @@ template("optional") {
}
}
-optional("android_framework_defines") {
- enabled = skia_enable_android_framework_defines
- public_defines = skia_android_framework_defines
-}
-
optional("fontmgr_android") {
enabled = fontmgr_android_enabled
@@ -392,7 +390,6 @@ component("skia") {
configs += skia_library_configs
deps = [
- ":android_framework_defines",
":arm64",
":armv7",
":avx",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698