Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1700)

Unified Diff: tools/dom/src/dart2js_CustomElementSupport.dart

Issue 23567006: Revert "Basic functionality is working with JS native support and polyfill, still some issues with … (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/html/html.status ('k') | tools/dom/templates/html/impl/impl_Element.darttemplate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/src/dart2js_CustomElementSupport.dart
diff --git a/tools/dom/src/dart2js_CustomElementSupport.dart b/tools/dom/src/dart2js_CustomElementSupport.dart
index 243f9beaf5cdaecd52c62556bf7a2c3a438712a2..95c64b678f51a7821c8c6dffc510de769523f684 100644
--- a/tools/dom/src/dart2js_CustomElementSupport.dart
+++ b/tools/dom/src/dart2js_CustomElementSupport.dart
@@ -18,32 +18,7 @@ _makeCreatedCallbackMethod() {
convertDartClosureToJS(_callCreated, 1));
}
-const _typeNameToTag = const {
- 'HTMLAnchorElement': 'a',
- 'HTMLAudioElement': 'audio',
- 'HTMLButtonElement': 'button',
- 'HTMLCanvasElement': 'canvas',
- 'HTMLDivElement': 'div',
- 'HTMLImageElement': 'img',
- 'HTMLInputElement': 'input',
- 'HTMLLIElement': 'li',
- 'HTMLLabelElement': 'label',
- 'HTMLMenuElement': 'menu',
- 'HTMLMeterElement': 'meter',
- 'HTMLOListElement': 'ol',
- 'HTMLOptionElement': 'option',
- 'HTMLOutputElement': 'output',
- 'HTMLParagraphElement': 'p',
- 'HTMLPreElement': 'pre',
- 'HTMLProgressElement': 'progress',
- 'HTMLSelectElement': 'select',
- 'HTMLSpanElement': 'span',
- 'HTMLUListElement': 'ul',
- 'HTMLVideoElement': 'video',
-};
-
-void _registerCustomElement(context, document, String tag, Type type,
- String nativeTagName) {
+void _registerCustomElement(context, document, String tag, Type type) {
// Function follows the same pattern as the following JavaScript code for
// registering a custom element.
//
@@ -85,15 +60,6 @@ void _registerCustomElement(context, document, String tag, Type type,
setNativeSubclassDispatchRecord(proto, interceptor);
- var options = JS('=Object', '{prototype: #}', proto);
-
- if (baseClassName != 'HTMLElement') {
- if (nativeTagName != null) {
- JS('=Object', '#.extends = #', options, nativeTagName);
- } else if (_typeNameToTag.containsKey(baseClassName)) {
- JS('=Object', '#.extends = #', options, _typeNameToTag[baseClassName]);
- }
- }
-
- JS('void', '#.register(#, #)', document, tag, options);
+ JS('void', '#.register(#, #)',
+ document, tag, JS('', '{prototype: #}', proto));
}
« no previous file with comments | « tests/html/html.status ('k') | tools/dom/templates/html/impl/impl_Element.darttemplate » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698