Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 23567004: Fix alignment for bidirectional text. (Closed)

Created:
7 years, 3 months ago by igoroliveira
Modified:
7 years, 3 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

In the css3-text spec: The start and end edges of a line box are determined by the inline base direction of the line box. In most cases, this is given by its containing block's computed ‘direction’. However if its containing block has ‘unicode-bidi: plaintext’, the inline base direction the line box must be determined by the base direction of the bidi paragraph to which it belongs: that is, the bidi paragraph for which the line box holds content. This patch just implements the behavior described above modifying updateLogicalWidthForAlignment and setting the bidi level of the RootInlineBox. Additionally, modify two layout tests to make it conforming to the spec. BUG=280709 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157263

Patch Set 1 #

Patch Set 2 : Rebaseline layouttests #

Patch Set 3 : Trying Again #

Messages

Total messages: 9 (0 generated)
igoroliveira
7 years, 3 months ago (2013-08-28 21:25:48 UTC) #1
eseidel
This looks reasonable. Levi?
7 years, 3 months ago (2013-09-03 18:30:09 UTC) #2
leviw_travelin_and_unemployed
The code change looks fine, and matching Firefox is a plus, but since this behavior ...
7 years, 3 months ago (2013-09-03 20:00:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/igor.o@sisa.samsung.com/23567004/1
7 years, 3 months ago (2013-09-04 20:22:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/igor.o@sisa.samsung.com/23567004/1
7 years, 3 months ago (2013-09-04 21:45:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/igor.o@sisa.samsung.com/23567004/19001
7 years, 3 months ago (2013-09-04 23:05:57 UTC) #6
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 3 months ago (2013-09-04 23:06:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/igor.o@sisa.samsung.com/23567004/25001
7 years, 3 months ago (2013-09-04 23:20:06 UTC) #8
commit-bot: I haz the power
7 years, 3 months ago (2013-09-05 02:27:08 UTC) #9
Message was sent while issue was closed.
Change committed as 157263

Powered by Google App Engine
This is Rietveld 408576698