Remove BytesConsumer::read

Remove BytesConsumer::read

BytesConsumer::read is rarely used, and it can be implemented on top of
two-phase read functions. Removing it allows endRead to return
Result::Done, which simplifies BytesConsumer implementations.

This CL also fixes a bug in BytesConsumerTestUtil.

BUG=610195
Committed: https://crrev.com/dc89b6cd125269af5033d6e6a158c12542c0785d
Cr-Commit-Position: refs/heads/master@{#419983}

[yhirano, 2016-09-20 05:53:54]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 05:54:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-09-20 05:54:31]

Description was changed from

==========
Remove BytesConsumer::read

BytesConsumer::read is rarely used, and it can be implemented on top of
two-phase read functions. Let's remove the function.

BUG=610195
==========

to

==========
Remove BytesConsumer::read

BytesConsumer::read is rarely used, and it can be implemented on top of
two-phase read functions. Let's remove the function.

This CL also changes |endRead| so that it can returns Done.

BUG=610195
==========

[yhirano, 2016-09-20 05:54:31]

yhirano@chromium.org changed reviewers:
+ hiroshige@chromium.org

[yhirano, 2016-09-20 06:31:24]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 06:31:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-09-20 06:42:03]

Description was changed from

==========
Remove BytesConsumer::read

BytesConsumer::read is rarely used, and it can be implemented on top of
two-phase read functions. Let's remove the function.

This CL also changes |endRead| so that it can returns Done.

BUG=610195
==========

to

==========
Remove BytesConsumer::read

BytesConsumer::read is rarely used, and it can be implemented on top of
two-phase read functions. Let's remove the function.

BUG=610195
==========

[commit-bot: I haz the power, 2016-09-20 07:31:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 07:31:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yhirano, 2016-09-20 07:48:02]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 07:48:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-09-20 08:44:42]

https://codereview.chromium.org/2356693002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/fetch/BytesConsumerTestUtil.cpp (right):

https://codereview.chromium.org/2356693002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/fetch/BytesConsumerTestUtil.cpp:169: size_t
read = std::min(static_cast<size_t>(3), available);
This is a separate bug. I found this bug in the process of this refactoring.
Since it's a small one let me fix this bug in this CL.

[commit-bot: I haz the power, 2016-09-20 08:49:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 08:49:37]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-09-20 09:00:23]

LGTM.

Mentioning
- the small bug fix and
- that removing read() will enable https://codereview.chromium.org/2351643004/
and thus enable us to omit async notification from endRead()
in the CL description would be helpful.

Allowing endRead() to return Done might complicates the BytesConsumer's users'
logic and might be prone to error (by failing to check the endRead() return
value appropriately), but removing read() simplifies the implementation and
might make BytesConsumer to have less corner cases (and thus less bugs).

[yhirano, 2016-09-20 12:48:55]

Description was changed from

==========
Remove BytesConsumer::read

BytesConsumer::read is rarely used, and it can be implemented on top of
two-phase read functions. Let's remove the function.

BUG=610195
==========

to

==========
Remove BytesConsumer::read

BytesConsumer::read is rarely used, and it can be implemented on top of
two-phase read functions. Removing it allows endRead to return Result::Done
, which simplifies BytesConsumer implementations. Let's remove
the function.

This CL also fixes a bug in BytesConsumerTestUtil. 

BUG=610195
==========

[yhirano, 2016-09-20 12:49:39]

Description was changed from

==========
Remove BytesConsumer::read

BytesConsumer::read is rarely used, and it can be implemented on top of
two-phase read functions. Removing it allows endRead to return Result::Done
, which simplifies BytesConsumer implementations. Let's remove
the function.

This CL also fixes a bug in BytesConsumerTestUtil. 

BUG=610195
==========

to

==========
Remove BytesConsumer::read

BytesConsumer::read is rarely used, and it can be implemented on top of
two-phase read functions. Removing it allows endRead to return
Result::Done, which simplifies BytesConsumer implementations.


This CL also fixes a bug in BytesConsumerTestUtil. 

BUG=610195
==========

[yhirano, 2016-09-20 12:49:53]

Description was changed from

==========
Remove BytesConsumer::read

BytesConsumer::read is rarely used, and it can be implemented on top of
two-phase read functions. Removing it allows endRead to return
Result::Done, which simplifies BytesConsumer implementations.


This CL also fixes a bug in BytesConsumerTestUtil. 

BUG=610195
==========

to

==========
Remove BytesConsumer::read

BytesConsumer::read is rarely used, and it can be implemented on top of
two-phase read functions. Removing it allows endRead to return
Result::Done, which simplifies BytesConsumer implementations.

This CL also fixes a bug in BytesConsumerTestUtil. 

BUG=610195
==========

[yhirano, 2016-09-20 12:50:44]

Updated the description.

[hiroshige, 2016-09-21 05:01:18]

On 2016/09/20 12:50:44, yhirano (slow) wrote:
> Updated the description.

lgtm again.

[yhirano, 2016-09-21 05:37:23]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2016-09-21 05:37:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 05:44:43]

Description was changed from

==========
Remove BytesConsumer::read

BytesConsumer::read is rarely used, and it can be implemented on top of
two-phase read functions. Removing it allows endRead to return
Result::Done, which simplifies BytesConsumer implementations.

This CL also fixes a bug in BytesConsumerTestUtil. 

BUG=610195
==========

to

==========
Remove BytesConsumer::read

BytesConsumer::read is rarely used, and it can be implemented on top of
two-phase read functions. Removing it allows endRead to return
Result::Done, which simplifies BytesConsumer implementations.

This CL also fixes a bug in BytesConsumerTestUtil. 

BUG=610195
==========

[commit-bot: I haz the power, 2016-09-21 05:44:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-21 05:47:58]

Description was changed from

==========
Remove BytesConsumer::read

BytesConsumer::read is rarely used, and it can be implemented on top of
two-phase read functions. Removing it allows endRead to return
Result::Done, which simplifies BytesConsumer implementations.

This CL also fixes a bug in BytesConsumerTestUtil. 

BUG=610195
==========

to

==========
Remove BytesConsumer::read

BytesConsumer::read is rarely used, and it can be implemented on top of
two-phase read functions. Removing it allows endRead to return
Result::Done, which simplifies BytesConsumer implementations.

This CL also fixes a bug in BytesConsumerTestUtil.

BUG=610195

Committed: https://crrev.com/dc89b6cd125269af5033d6e6a158c12542c0785d
Cr-Commit-Position: refs/heads/master@{#419983}
==========

[commit-bot: I haz the power, 2016-09-21 05:48:02]

Patchset 3 (id:??) landed as
https://crrev.com/dc89b6cd125269af5033d6e6a158c12542c0785d
Cr-Commit-Position: refs/heads/master@{#419983}