Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2351643004: BytesConsumer::endRead can return Done (Closed)

Created:
4 years, 3 months ago by yhirano
Modified:
4 years, 3 months ago
Reviewers:
hiroshige
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

BytesConsumer::endRead can return Done This CL changes a BytesConsumer::endRead expectation. It can return Result::Done and a caller needs to handle the return value. BUG=610195 Committed: https://crrev.com/9f62432cd166eaeb2ac12b2a48bf6f0bf52cfa1b Cr-Commit-Position: refs/heads/master@{#419985}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -60 lines) Patch
M third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp View 2 chunks +11 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/BytesConsumer.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/BytesConsumer.cpp View 1 chunk +17 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/BytesConsumerTestUtil.cpp View 1 1 chunk +8 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchDataLoader.cpp View 5 chunks +39 lines, -27 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (11 generated)
yhirano
4 years, 3 months ago (2016-09-20 08:54:31 UTC) #7
hiroshige
lgtm.
4 years, 3 months ago (2016-09-21 05:12:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351643004/20001
4 years, 3 months ago (2016-09-21 05:45:42 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-21 05:54:55 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 05:56:41 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9f62432cd166eaeb2ac12b2a48bf6f0bf52cfa1b
Cr-Commit-Position: refs/heads/master@{#419985}

Powered by Google App Engine
This is Rietveld 408576698