[Findit] Add cracas config in config page.

[Findit] Add cracas config in config page.

New config page: https://findit-for-me.googleplex.com/crash/config

BUG=645203
Committed: https://chromium.googlesource.com/infra/infra/+/c2a5bf2e88339240308928d1f7c18faeda2d939a

[Sharu Jiang, 2016-09-20 01:34:34]

Description was changed from

==========
[Findit] Add cracas config in config page.

BUG=
==========

to

==========
[Findit] Add cracas config in config page.

BUG=645203
==========

[Sharu Jiang, 2016-09-20 01:34:34]

katesonia@chromium.org changed reviewers:
+ chanli@chromium.org, lijeffrey@chromium.org, mbarbella@google.com,
stgao@chromium.org, wrengr@chromium.org

[Sharu Jiang, 2016-09-20 01:40:00]

Description was changed from

==========
[Findit] Add cracas config in config page.

BUG=645203
==========

to

==========
[Findit] Add cracas config in config page.

New config page: https://findit-for-me.googleplex.com/crash/config

BUG=645203
==========

[Sharu Jiang, 2016-09-20 01:40:17]

PTAL :)

[lijeffrey, 2016-09-20 05:36:43]

lgtm

[Martin Barbella, 2016-09-20 16:01:47]

mbarbella@chromium.org changed reviewers:
+ mbarbella@chromium.org

[Martin Barbella, 2016-09-20 16:01:47]

lgtm

[mmandlis, 2016-09-20 17:33:55]

mmandlis@chromium.org changed reviewers:
+ mmandlis@chromium.org

[mmandlis, 2016-09-20 17:33:56]

lgtm

https://codereview.chromium.org/2356673002/diff/1/appengine/findit/model/cras...
File appengine/findit/model/crash/crash_config.py (right):

https://codereview.chromium.org/2356673002/diff/1/appengine/findit/model/cras...
appengine/findit/model/crash/crash_config.py:35: #     "canary": ["win", "mac"],
why is only "win" and "mac" supported? what is preventing us from enabling it
for other platforms?

[Sharu Jiang, 2016-09-20 18:02:57]

https://codereview.chromium.org/2356673002/diff/1/appengine/findit/model/cras...
File appengine/findit/model/crash/crash_config.py (right):

https://codereview.chromium.org/2356673002/diff/1/appengine/findit/model/cras...
appengine/findit/model/crash/crash_config.py:35: #     "canary": ["win", "mac"],
On 2016/09/20 17:33:56, mmandlis wrote:
> why is only "win" and "mac" supported? what is preventing us from enabling it
> for other platforms?

This comment is an example of what cracas config looks like, it's not exactly
the same as in config page. In config page, we will support:
    "canary": [
      "win",
      "mac",
      "android",
      "linux"
    ]

After some testing, we will enable other channels as well.

[stgao, 2016-09-20 18:07:12]

lgtm with nit.

https://codereview.chromium.org/2356673002/diff/1/appengine/findit/model/cras...
File appengine/findit/model/crash/crash_config.py (right):

https://codereview.chromium.org/2356673002/diff/1/appengine/findit/model/cras...
appengine/findit/model/crash/crash_config.py:35: #     "canary": ["win", "mac"],
On 2016/09/20 18:02:57, sharu jiang wrote:
> On 2016/09/20 17:33:56, mmandlis wrote:
> > why is only "win" and "mac" supported? what is preventing us from enabling
it
> > for other platforms?
> 
> This comment is an example of what cracas config looks like, it's not exactly
> the same as in config page. In config page, we will support:
>     "canary": [
>       "win",
>       "mac",
>       "android",
>       "linux"
>     ]
> 
> After some testing, we will enable other channels as well.

nit: make it clear that it is an example of the config.
Sorry for my bad sample above.

[Sharu Jiang, 2016-09-20 20:45:07]

https://codereview.chromium.org/2356673002/diff/1/appengine/findit/model/cras...
File appengine/findit/model/crash/crash_config.py (right):

https://codereview.chromium.org/2356673002/diff/1/appengine/findit/model/cras...
appengine/findit/model/crash/crash_config.py:35: #     "canary": ["win", "mac"],
On 2016/09/20 18:07:12, stgao (slow) wrote:
> On 2016/09/20 18:02:57, sharu jiang wrote:
> > On 2016/09/20 17:33:56, mmandlis wrote:
> > > why is only "win" and "mac" supported? what is preventing us from enabling
> it
> > > for other platforms?
> > 
> > This comment is an example of what cracas config looks like, it's not
exactly
> > the same as in config page. In config page, we will support:
> >     "canary": [
> >       "win",
> >       "mac",
> >       "android",
> >       "linux"
> >     ]
> > 
> > After some testing, we will enable other channels as well.
> 
> nit: make it clear that it is an example of the config.
> Sorry for my bad sample above.

Done.

[Sharu Jiang, 2016-09-21 20:36:58]

The CQ bit was checked by katesonia@chromium.org

[Sharu Jiang, 2016-09-21 20:36:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
lijeffrey@chromium.org, mbarbella@chromium.org, mmandlis@chromium.org,
stgao@chromium.org
Link to the patchset: https://codereview.chromium.org/2356673002/#ps40001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-09-21 20:37:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 21:18:16]

Description was changed from

==========
[Findit] Add cracas config in config page.

New config page: https://findit-for-me.googleplex.com/crash/config

BUG=645203
==========

to

==========
[Findit] Add cracas config in config page.

New config page: https://findit-for-me.googleplex.com/crash/config

BUG=645203

Committed:
https://chromium.googlesource.com/infra/infra/+/c2a5bf2e88339240308928d1f7c18...
==========

[commit-bot: I haz the power, 2016-09-21 21:18:17]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/c2a5bf2e88339240308928d1f7c18...