Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2356673002: [Findit] Add cracas config in config page. (Closed)

Created:
4 years, 3 months ago by Sharu Jiang
Modified:
4 years, 3 months ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org, mmandlis, ymzhang1
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Update comments. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -3 lines) Patch
M appengine/findit/handlers/crash/crash_config.py View 1 chunk +1 line, -0 lines 0 comments Download
M appengine/findit/model/crash/crash_config.py View 1 2 chunks +20 lines, -3 lines 0 comments Download
M appengine/findit/templates/crash/crash_config.html View 4 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Sharu Jiang
PTAL :)
4 years, 3 months ago (2016-09-20 01:40:17 UTC) #4
lijeffrey
lgtm
4 years, 3 months ago (2016-09-20 05:36:43 UTC) #5
Martin Barbella
lgtm
4 years, 3 months ago (2016-09-20 16:01:47 UTC) #7
mmandlis
lgtm https://codereview.chromium.org/2356673002/diff/1/appengine/findit/model/crash/crash_config.py File appengine/findit/model/crash/crash_config.py (right): https://codereview.chromium.org/2356673002/diff/1/appengine/findit/model/crash/crash_config.py#newcode35 appengine/findit/model/crash/crash_config.py:35: # "canary": ["win", "mac"], why is only "win" ...
4 years, 3 months ago (2016-09-20 17:33:56 UTC) #9
Sharu Jiang
https://codereview.chromium.org/2356673002/diff/1/appengine/findit/model/crash/crash_config.py File appengine/findit/model/crash/crash_config.py (right): https://codereview.chromium.org/2356673002/diff/1/appengine/findit/model/crash/crash_config.py#newcode35 appengine/findit/model/crash/crash_config.py:35: # "canary": ["win", "mac"], On 2016/09/20 17:33:56, mmandlis wrote: ...
4 years, 3 months ago (2016-09-20 18:02:57 UTC) #10
stgao
lgtm with nit. https://codereview.chromium.org/2356673002/diff/1/appengine/findit/model/crash/crash_config.py File appengine/findit/model/crash/crash_config.py (right): https://codereview.chromium.org/2356673002/diff/1/appengine/findit/model/crash/crash_config.py#newcode35 appengine/findit/model/crash/crash_config.py:35: # "canary": ["win", "mac"], On 2016/09/20 ...
4 years, 3 months ago (2016-09-20 18:07:12 UTC) #11
Sharu Jiang
https://codereview.chromium.org/2356673002/diff/1/appengine/findit/model/crash/crash_config.py File appengine/findit/model/crash/crash_config.py (right): https://codereview.chromium.org/2356673002/diff/1/appengine/findit/model/crash/crash_config.py#newcode35 appengine/findit/model/crash/crash_config.py:35: # "canary": ["win", "mac"], On 2016/09/20 18:07:12, stgao (slow) ...
4 years, 3 months ago (2016-09-20 20:45:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356673002/40001
4 years, 3 months ago (2016-09-21 20:37:02 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 21:18:17 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/c2a5bf2e88339240308928d1f7c18...

Powered by Google App Engine
This is Rietveld 408576698