Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: appengine/findit/model/crash/crash_config.py

Issue 2356673002: [Findit] Add cracas config in config page. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Findit for crash (ClusterFuzz & Fracas/Chromecrash) configuration.""" 5 """Findit for crash (ClusterFuzz & Fracas/Chromecrash) configuration."""
6 6
7 import re 7 import re
8 8
9 from google.appengine.ext import ndb 9 from google.appengine.ext import ndb
10 10
(...skipping 10 matching lines...) Expand all
21 21
22 # Fracas-specific parameters. 22 # Fracas-specific parameters.
23 # { 23 # {
24 # "analysis_result_pubsub_topic": "projects/project-name/topics/name", 24 # "analysis_result_pubsub_topic": "projects/project-name/topics/name",
25 # "supported_platform_list_by_channel": { 25 # "supported_platform_list_by_channel": {
26 # "canary": ["win", "mac"], 26 # "canary": ["win", "mac"],
27 # }, 27 # },
28 # } 28 # }
29 fracas = ndb.JsonProperty(indexed=False, default={}) 29 fracas = ndb.JsonProperty(indexed=False, default={})
30 30
31 # Cracas-specific parameters.
32 # {
33 # "analysis_result_pubsub_topic": "projects/project-name/topics/name",
34 # "supported_platform_list_by_channel": {
35 # "canary": ["win", "mac"],
mmandlis 2016/09/20 17:33:56 why is only "win" and "mac" supported? what is pre
Sharu Jiang 2016/09/20 18:02:57 This comment is an example of what cracas config l
stgao 2016/09/20 18:07:12 nit: make it clear that it is an example of the co
Sharu Jiang 2016/09/20 20:45:07 Done.
36 # },
37 # }
38 cracas = ndb.JsonProperty(indexed=False, default={})
39
31 ################## Settings shared by Fracas/Clusterfuzz. ################## 40 ################## Settings shared by Fracas/Clusterfuzz. ##################
32 # Project classifier settings: 41 # Project classifier settings:
33 # { 42 # {
34 # "host_directories": [ 43 # "host_directories": [
35 # "src/chrome/browser/resources/", 44 # "src/chrome/browser/resources/",
36 # "src/chrome/test/data/layout_tests/", 45 # "src/chrome/test/data/layout_tests/",
37 # "src/media/", 46 # "src/media/",
38 # "src/sdch/", 47 # "src/sdch/",
39 # "src/testing/", 48 # "src/testing/",
40 # "src/third_party/WebKit/", 49 # "src/third_party/WebKit/",
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 if client_id == CrashClient.FRACAS: 120 if client_id == CrashClient.FRACAS:
112 return self.fracas 121 return self.fracas
113 elif client_id == CrashClient.CRACAS: # pragma: no cover. 122 elif client_id == CrashClient.CRACAS: # pragma: no cover.
114 # TODO(katesonia): Add crash config of cracas. 123 # TODO(katesonia): Add crash config of cracas.
115 return None 124 return None
116 elif client_id == CrashClient.CLUSTERFUZZ: # pragma: no cover. 125 elif client_id == CrashClient.CLUSTERFUZZ: # pragma: no cover.
117 # TODO(katesonia): Add crash config of clusterfuzz. 126 # TODO(katesonia): Add crash config of clusterfuzz.
118 return None 127 return None
119 128
120 return None 129 return None
OLDNEW
« no previous file with comments | « appengine/findit/handlers/crash/crash_config.py ('k') | appengine/findit/templates/crash/crash_config.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698