Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 2356603002: Remove "gn check" whitelist for //chrome/browser/ui (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
Reviewers:
Dmitry Titov
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove "gn check" whitelist for //chrome/browser/ui This still fails on Windows official builds. This is in lieu of reverting all of https://codereview.chromium.org/2354633002 TBR=dimich@chromium.org NOTRY=true Committed: https://crrev.com/68e67b89c57be31dd3011de83986222b1227e0c8 Cr-Commit-Position: refs/heads/master@{#419592}

Patch Set 1 #

Patch Set 2 : Grammar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M .gn View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
brettw
Grammar
4 years, 3 months ago (2016-09-19 22:21:03 UTC) #1
brettw
4 years, 3 months ago (2016-09-19 22:21:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356603002/20001
4 years, 3 months ago (2016-09-19 22:22:41 UTC) #5
Dmitry Titov
lgtm
4 years, 3 months ago (2016-09-19 22:24:26 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-19 22:28:01 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 22:29:50 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/68e67b89c57be31dd3011de83986222b1227e0c8
Cr-Commit-Position: refs/heads/master@{#419592}

Powered by Google App Engine
This is Rietveld 408576698