Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6883)

Unified Diff: chrome/test/chromedriver/chrome/devtools_client_impl.h

Issue 23566018: [chromedriver] Remove Logger and just use base LOG. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/devtools_client_impl.h
diff --git a/chrome/test/chromedriver/chrome/devtools_client_impl.h b/chrome/test/chromedriver/chrome/devtools_client_impl.h
index 1fe1f0a870f0761436841cb9d7a0303d0e7901bf..cd33f534b6da28fbe3e1eb5ba5a4389972a09ea5 100644
--- a/chrome/test/chromedriver/chrome/devtools_client_impl.h
+++ b/chrome/test/chromedriver/chrome/devtools_client_impl.h
@@ -47,7 +47,6 @@ struct InspectorCommandResponse {
} // namespace internal
class DevToolsEventListener;
-class Log;
class Status;
class SyncWebSocket;
@@ -57,8 +56,7 @@ class DevToolsClientImpl : public DevToolsClient {
DevToolsClientImpl(const SyncWebSocketFactory& factory,
const std::string& url,
const std::string& id,
- const FrontendCloserFunc& frontend_closer_func,
- Log* log);
+ const FrontendCloserFunc& frontend_closer_func);
typedef base::Callback<bool(
const std::string&,
@@ -70,7 +68,6 @@ class DevToolsClientImpl : public DevToolsClient {
const std::string& url,
const std::string& id,
const FrontendCloserFunc& frontend_closer_func,
- Log* log,
const ParserFunc& parser_func);
virtual ~DevToolsClientImpl();
@@ -130,7 +127,6 @@ class DevToolsClientImpl : public DevToolsClient {
GURL url_;
const std::string id_;
FrontendCloserFunc frontend_closer_func_;
- Log* log_;
ParserFunc parser_func_;
std::list<DevToolsEventListener*> listeners_;
std::list<DevToolsEventListener*> unnotified_connect_listeners_;
« no previous file with comments | « chrome/test/chromedriver/chrome/console_logger_unittest.cc ('k') | chrome/test/chromedriver/chrome/devtools_client_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698