chrome/test/chromedriver/chrome/console_logger_unittest.cc - Issue 23566018: [chromedriver] Remove Logger and just use base LOG.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/console_logger_unittest.cc

Issue 23566018: [chromedriver] Remove Logger and just use base LOG. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address comments Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/chrome/console_logger_unittest.cc

diff --git a/chrome/test/chromedriver/chrome/console_logger_unittest.cc b/chrome/test/chromedriver/chrome/console_logger_unittest.cc

index 8250842e6a841dd696a9e490592be7d7dd97ba1c..89798c78425fc608e07edc71047a4177e2c971d6 100644

--- a/chrome/test/chromedriver/chrome/console_logger_unittest.cc

+++ b/chrome/test/chromedriver/chrome/console_logger_unittest.cc

@@ -173,7 +173,7 @@ TEST(ConsoleLogger, ConsoleMessages) {

ASSERT_EQ(8u, log.GetEntries().size());

ValidateLogEntry(log.GetEntries()[0], Log::kDebug, "url1 10:1 text1");

- ValidateLogEntry(log.GetEntries()[1], Log::kLog, "source2 - text2");

+ ValidateLogEntry(log.GetEntries()[1], Log::kInfo, "source2 - text2");

ValidateLogEntry(log.GetEntries()[2], Log::kWarning, "url3 30 text3");

ValidateLogEntry(log.GetEntries()[3], Log::kError, "url4 - text4");

ValidateLogEntry(