Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: chrome/browser/resources/gallery/manifest.json

Issue 235653003: Gallery.app: Add empty place holders for new separated Gallery app. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix non-chromeos build. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/gallery/js/test_util.js ('k') | chromeos/chromeos_switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/gallery/manifest.json
diff --git a/chrome/browser/resources/video_player/manifest.json b/chrome/browser/resources/gallery/manifest.json
similarity index 74%
copy from chrome/browser/resources/video_player/manifest.json
copy to chrome/browser/resources/gallery/manifest.json
index 5478a98b30ab65ed860acc13714b63221f414e70..2e02094d73da5f3614119537e2bd91c93f771872 100644
--- a/chrome/browser/resources/video_player/manifest.json
+++ b/chrome/browser/resources/gallery/manifest.json
@@ -2,9 +2,9 @@
// chrome-extension://jcgeabjmjgoblfofpppfkcoakmfobdko/
"key": "MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAw0/gRbJc545iEGRZs20Rl/HtrSUp8H3gJd4Y6hCe0CG1xQiJhZ5nc8qZyxa96gMxRAKBq54S6sjVVtV6uS70oU6FvrvwItByYkkqr4ZE7eMJKwMqnGItxWbh6KBodf89lpKoIy6MtYTqubBhXB/IQBZsXah90tXwRzaaJNWw+2BBRIhcPsH3ng+wgN7rwFxo4HIv9ZpqkYlx90rwkfjOmKPPnSXyXFIBJfmqfdbd8PLtcxzzOTE+vxwoXZuYWrthKm4uKfNqXIYns74sSJlqyKfctuR+nQdNh8uePv0e+/Ul3wER1/jIXULLjfyoaklyDs+ak3SDf+xWScJ+0LJ0AwIDAQAB",
"manifest_version": 2,
- "name": "Video Player",
+ "name": "New Gallery",
mtomasz 2014/04/15 03:14:03 nit: I think just "Gallery" is fine.
hirono 2014/04/15 03:49:41 Done.
"version": "1.0",
mtomasz 2014/04/15 03:14:03 nit: But we could increment the version instead of
hirono 2014/04/15 03:49:41 Done.
- "description": "Video Player",
+ "description": "Gallery application of Chrome OS",
mtomasz 2014/04/15 03:14:03 nit: How about: 'Picture and video browser app.'?
hirono 2014/04/15 03:49:41 Done.
"display_in_launcher": false,
"incognito" : "split",
"icons": {
@@ -22,33 +22,26 @@
"file_handlers": {
"video": {
"types": [
- "video/*"
+ "image/*"
],
"extensions": [
- "3gp",
- "avi",
- "m4v",
- "mkv",
- "mov",
- "mp4",
- "mpeg",
- "mpeg4",
- "mpg",
- "mpg4",
- "ogm",
- "ogv",
- "ogx",
- "webm"
+ "bmp",
+ "gif",
+ "ico",
+ "jpg",
+ "jpeg",
+ "png",
+ "webp"
],
- // TODO(yoshiki): localize this.
- "title": "Watch"
+ // TODO(hirono): Rename and localize this.
+ "title": "Open with new Gallery"
mtomasz 2014/04/15 03:14:03 nit: 'Open in Gallery'?
hirono 2014/04/15 03:49:41 Can I keep 'new' as long as the feature is behind
}
},
"app": {
"background": {
"scripts": [
- "js/error_util.js",
- "js/test_util.js",
+ // "js/error_util.js",
mtomasz 2014/04/15 03:14:03 nit: Why is this commented out?
hirono 2014/04/15 03:49:41 Oops, remove the comment out symbols.
+ // "js/test_util.js",
"js/background.js"
]
},
« no previous file with comments | « chrome/browser/resources/gallery/js/test_util.js ('k') | chromeos/chromeos_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698