Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 { | 1 { |
| 2 // chrome-extension://jcgeabjmjgoblfofpppfkcoakmfobdko/ | 2 // chrome-extension://jcgeabjmjgoblfofpppfkcoakmfobdko/ |
| 3 "key": "MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAw0/gRbJc545iEGRZs20Rl/HtrS Up8H3gJd4Y6hCe0CG1xQiJhZ5nc8qZyxa96gMxRAKBq54S6sjVVtV6uS70oU6FvrvwItByYkkqr4ZE7e MJKwMqnGItxWbh6KBodf89lpKoIy6MtYTqubBhXB/IQBZsXah90tXwRzaaJNWw+2BBRIhcPsH3ng+wgN 7rwFxo4HIv9ZpqkYlx90rwkfjOmKPPnSXyXFIBJfmqfdbd8PLtcxzzOTE+vxwoXZuYWrthKm4uKfNqXI Yns74sSJlqyKfctuR+nQdNh8uePv0e+/Ul3wER1/jIXULLjfyoaklyDs+ak3SDf+xWScJ+0LJ0AwIDAQ AB", | 3 "key": "MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAw0/gRbJc545iEGRZs20Rl/HtrS Up8H3gJd4Y6hCe0CG1xQiJhZ5nc8qZyxa96gMxRAKBq54S6sjVVtV6uS70oU6FvrvwItByYkkqr4ZE7e MJKwMqnGItxWbh6KBodf89lpKoIy6MtYTqubBhXB/IQBZsXah90tXwRzaaJNWw+2BBRIhcPsH3ng+wgN 7rwFxo4HIv9ZpqkYlx90rwkfjOmKPPnSXyXFIBJfmqfdbd8PLtcxzzOTE+vxwoXZuYWrthKm4uKfNqXI Yns74sSJlqyKfctuR+nQdNh8uePv0e+/Ul3wER1/jIXULLjfyoaklyDs+ak3SDf+xWScJ+0LJ0AwIDAQ AB", |
| 4 "manifest_version": 2, | 4 "manifest_version": 2, |
| 5 "name": "Video Player", | 5 "name": "New Gallery", |
|
mtomasz
2014/04/15 03:14:03
nit: I think just "Gallery" is fine.
hirono
2014/04/15 03:49:41
Done.
| |
| 6 "version": "1.0", | 6 "version": "1.0", |
|
mtomasz
2014/04/15 03:14:03
nit: But we could increment the version instead of
hirono
2014/04/15 03:49:41
Done.
| |
| 7 "description": "Video Player", | 7 "description": "Gallery application of Chrome OS", |
|
mtomasz
2014/04/15 03:14:03
nit: How about: 'Picture and video browser app.'?
hirono
2014/04/15 03:49:41
Done.
| |
| 8 "display_in_launcher": false, | 8 "display_in_launcher": false, |
| 9 "incognito" : "split", | 9 "incognito" : "split", |
| 10 "icons": { | 10 "icons": { |
| 11 "16": "images/100/icon.png", | 11 "16": "images/100/icon.png", |
| 12 "32": "images/200/icon.png" | 12 "32": "images/200/icon.png" |
| 13 }, | 13 }, |
| 14 "permissions": [ | 14 "permissions": [ |
| 15 "fileSystem", | 15 "fileSystem", |
| 16 "fileBrowserPrivate", | 16 "fileBrowserPrivate", |
| 17 "fullscreen", | 17 "fullscreen", |
| 18 "mediaPlayerPrivate", | 18 "mediaPlayerPrivate", |
| 19 "storage", | 19 "storage", |
| 20 "chrome://theme/" | 20 "chrome://theme/" |
| 21 ], | 21 ], |
| 22 "file_handlers": { | 22 "file_handlers": { |
| 23 "video": { | 23 "video": { |
| 24 "types": [ | 24 "types": [ |
| 25 "video/*" | 25 "image/*" |
| 26 ], | 26 ], |
| 27 "extensions": [ | 27 "extensions": [ |
| 28 "3gp", | 28 "bmp", |
| 29 "avi", | 29 "gif", |
| 30 "m4v", | 30 "ico", |
| 31 "mkv", | 31 "jpg", |
| 32 "mov", | 32 "jpeg", |
| 33 "mp4", | 33 "png", |
| 34 "mpeg", | 34 "webp" |
| 35 "mpeg4", | |
| 36 "mpg", | |
| 37 "mpg4", | |
| 38 "ogm", | |
| 39 "ogv", | |
| 40 "ogx", | |
| 41 "webm" | |
| 42 ], | 35 ], |
| 43 // TODO(yoshiki): localize this. | 36 // TODO(hirono): Rename and localize this. |
| 44 "title": "Watch" | 37 "title": "Open with new Gallery" |
|
mtomasz
2014/04/15 03:14:03
nit: 'Open in Gallery'?
hirono
2014/04/15 03:49:41
Can I keep 'new' as long as the feature is behind
| |
| 45 } | 38 } |
| 46 }, | 39 }, |
| 47 "app": { | 40 "app": { |
| 48 "background": { | 41 "background": { |
| 49 "scripts": [ | 42 "scripts": [ |
| 50 "js/error_util.js", | 43 // "js/error_util.js", |
|
mtomasz
2014/04/15 03:14:03
nit: Why is this commented out?
hirono
2014/04/15 03:49:41
Oops, remove the comment out symbols.
| |
| 51 "js/test_util.js", | 44 // "js/test_util.js", |
| 52 "js/background.js" | 45 "js/background.js" |
| 53 ] | 46 ] |
| 54 }, | 47 }, |
| 55 "content_security_policy": "default-src 'none'; script-src 'self'; style-src 'self' 'unsafe-inline'; img-src 'self' chrome://theme data:; media-src 'self'; object-src 'self'" | 48 "content_security_policy": "default-src 'none'; script-src 'self'; style-src 'self' 'unsafe-inline'; img-src 'self' chrome://theme data:; media-src 'self'; object-src 'self'" |
| 56 } | 49 } |
| 57 } | 50 } |
| OLD | NEW |