Issue 235653002: WebAudio createBuffer should throw error with 0 channels.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 235653002: WebAudio createBuffer should throw error with 0 channels. (Closed)

Created:
6 years, 8 months ago by Raymond Toy

Modified:
6 years, 7 months ago

Reviewers:
Ken Russell (switch to Gerrit)

CC:
blink-reviews, Raymond Toy

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

WebAudio createBuffer should throw error with 0 channels. Also moved the testing for invalid values from AudioContext::createBuffer to AudioBuffer::create, which knows what the valid ranges are instead of having the tests in both AudioBuffer::create and AudioContext::createBuffer. Test case added for createBuffer(0,...). BUG=362657 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173689

Patch Set 1 : #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -31 lines)			Patch
M	LayoutTests/webaudio/dom-exceptions.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/webaudio/dom-exceptions-expected.txt	View	1 chunk	+5 lines, -4 lines	0 comments	Download
M	Source/modules/webaudio/AudioBuffer.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/modules/webaudio/AudioBuffer.cpp	View	3 chunks	+55 lines, -1 line	0 comments	Download
M	Source/modules/webaudio/AudioContext.cpp	View	1 chunk	+1 line, -26 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtoy@chromium.org/235653002/20001

6 years, 7 months ago (2014-05-08 21:53:52 UTC) #4

Message was sent while issue was closed.

Change committed as 173689

Expand Messages | Collapse Messages