Source/modules/webaudio/AudioBuffer.h - Issue 235653002: WebAudio createBuffer should throw error with 0 channels.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webaudio/AudioBuffer.h

Issue 235653002: WebAudio createBuffer should throw error with 0 channels. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/webaudio/AudioBuffer.h

diff --git a/Source/modules/webaudio/AudioBuffer.h b/Source/modules/webaudio/AudioBuffer.h

index a7627bed7c57625d07a046809c4665ad74a56381..91c598f3cd4597ac9f87e621ba18b3dc9ea4afaf 100644

--- a/Source/modules/webaudio/AudioBuffer.h

+++ b/Source/modules/webaudio/AudioBuffer.h

@@ -44,6 +44,7 @@ class ExceptionState;

class AudioBuffer : public ScriptWrappable, public RefCounted<AudioBuffer> {

public:

static PassRefPtr<AudioBuffer> create(unsigned numberOfChannels, size_t numberOfFrames, float sampleRate);

+ static PassRefPtr<AudioBuffer> create(unsigned numberOfChannels, size_t numberOfFrames, float sampleRate, ExceptionState&);

// Returns 0 if data is not a valid audio file.

static PassRefPtr<AudioBuffer> createFromAudioFileData(const void* data, size_t dataSize, bool mixToMono, float sampleRate);