chrome/test/data/extensions/platform_apps/web_view/geolocation/embedder_has_no_permission/embedder.js - Issue 235633002: <webview>: Move Geolocation permission to chrome layer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/platform_apps/web_view/geolocation/embedder_has_no_permission/embedder.js

Issue 235633002: <webview>: Move Geolocation permission to chrome layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reordered permission names Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/extensions/platform_apps/web_view/geolocation/cancel_request/embedder.js ('K') | « chrome/test/data/extensions/platform_apps/web_view/geolocation/cancel_request/embedder.js ('k') | chrome/test/data/extensions/platform_apps/web_view/geolocation/embedder_has_permission/embedder.js » ('j') | content/public/browser/browser_plugin_guest_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/platform_apps/web_view/geolocation/embedder_has_no_permission/embedder.js

diff --git a/chrome/test/data/extensions/platform_apps/web_view/geolocation/embedder_has_no_permission/embedder.js b/chrome/test/data/extensions/platform_apps/web_view/geolocation/embedder_has_no_permission/embedder.js

index 08d5086137e530f03393368f84121803656077d8..08801e3ab305aae75e8c769f8a0654c805dcb265 100644

--- a/chrome/test/data/extensions/platform_apps/web_view/geolocation/embedder_has_no_permission/embedder.js

+++ b/chrome/test/data/extensions/platform_apps/web_view/geolocation/embedder_has_no_permission/embedder.js

@@ -99,10 +99,6 @@ embedder.assertCorrectEvent_ = function(e) {

embedder.test.assertEq('geolocation', e.permission);

embedder.test.assertTrue(!!e.url);

embedder.test.assertTrue(e.url.indexOf(embedder.baseGuestURL) == 0);

- // Check that unexpected properties (from other permissionrequest) do not show

- // up in the event object.

- embedder.test.assertFalse('userGesture' in e);

};

// Tests begin.