chrome/test/data/extensions/platform_apps/web_view/geolocation/cancel_request/embedder.js - Issue 235633002: <webview>: Move Geolocation permission to chrome layer.

Unified Diff: chrome/test/data/extensions/platform_apps/web_view/geolocation/cancel_request/embedder.js

Issue 235633002: <webview>: Move Geolocation permission to chrome layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reordered permission names Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/guestview/webview/webview_guest.cc ('K') | « chrome/browser/guestview/webview/webview_permission_types.h ('k') | chrome/test/data/extensions/platform_apps/web_view/geolocation/embedder_has_no_permission/embedder.js » ('j') | content/public/browser/browser_plugin_guest_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/platform_apps/web_view/geolocation/cancel_request/embedder.js

diff --git a/chrome/test/data/extensions/platform_apps/web_view/geolocation/cancel_request/embedder.js b/chrome/test/data/extensions/platform_apps/web_view/geolocation/cancel_request/embedder.js

index 9805e02facdf440d6517a76e01116bddb4c60916..f12d16fcd4eb66d2fe9b90f48346c1b5be44c385 100644

--- a/chrome/test/data/extensions/platform_apps/web_view/geolocation/cancel_request/embedder.js

+++ b/chrome/test/data/extensions/platform_apps/web_view/geolocation/cancel_request/embedder.js

@@ -71,10 +71,6 @@ embedder.assertCorrectEvent_ = function(e) {

chrome.test.assertEq('geolocation', e.permission);

chrome.test.assertTrue(!!e.url);

chrome.test.assertTrue(e.url.indexOf(embedder.baseGuestURL) == 0);

lazyboy 2014/04/11 21:47:21 Why do you remove these? Do they start getting def

Fady Samuel 2014/04/11 21:57:16 Geolocation recently got a "userGesture". I now pl

lazyboy 2014/04/11 22:00:53 Please add this to the CL description.

Fady Samuel 2014/04/14 17:30:02 Done.

- // Check that unexpected properties (from other permissionrequest) do not show

- // up in the event object.

- chrome.test.assertFalse('userGesture' in e);

};

var g_requestObject;