Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: tools/metrics/actions/actions.xml

Issue 235633002: <webview>: Move Geolocation permission to chrome layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated actions.xml Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/common/browser_plugin_permission_type.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/actions/actions.xml
diff --git a/tools/metrics/actions/actions.xml b/tools/metrics/actions/actions.xml
index c2915fb76e2e56592108f48dc1e2ddda22781ad4..4529f27cfe7a52167b56b50c5bbdfafc9cd15e84 100644
--- a/tools/metrics/actions/actions.xml
+++ b/tools/metrics/actions/actions.xml
@@ -1713,11 +1713,6 @@ should be able to be added at any place in this file.
<description>Please enter the description of this user action.</description>
</action>
-<action name="BrowserPlugin.PermissionAllow.Geolocation">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
- <description>Please enter the description of this user action.</description>
-</action>
-
<action name="BrowserPlugin.PermissionAllow.JSDialog">
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<description>Please enter the description of this user action.</description>
@@ -1743,11 +1738,6 @@ should be able to be added at any place in this file.
<description>Please enter the description of this user action.</description>
</action>
-<action name="BrowserPlugin.PermissionDeny.Geolocation">
Alexei Svitkine (slow) 2014/04/14 20:36:30 Instead of removing these, please mark them as obs
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
- <description>Please enter the description of this user action.</description>
-</action>
-
<action name="BrowserPlugin.PermissionDeny.JSDialog">
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<description>Please enter the description of this user action.</description>
@@ -10708,6 +10698,22 @@ should be able to be added at any place in this file.
<description>Please enter the description of this user action.</description>
</action>
+<action name="WebView.PermissionAllow.Geolocation">
+ <owner>fsamuel@chromium.org</owner>
+ <owner>lazyboy@chromium.org</owner>
+ <description>
+ Tracks when the geolocation permission is explicitly allowed on a webview.
+ </description>
+</action>
+
+<action name="WebView.PermissionDeny.Geolocation">
+ <owner>fsamuel@chromium.org</owner>
+ <owner>lazyboy@chromium.org</owner>
+ <description>
+ Tracks when the geolocation permission is explicitly denied on a webview.
+ </description>
+</action>
+
<action name="WebView.Reload">
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<description>Please enter the description of this user action.</description>
« no previous file with comments | « content/public/common/browser_plugin_permission_type.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698