Chromium Code Reviews Chromium Code Reviews
Issue 235633002:
<webview>: Move Geolocation permission to chrome layer. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 <!-- | 1 <!-- |
| 2 Copyright 2014 The Chromium Authors. All rights reserved. | 2 Copyright 2014 The Chromium Authors. All rights reserved. |
| 3 Use of this source code is governed by a BSD-style license that can be | 3 Use of this source code is governed by a BSD-style license that can be |
| 4 found in the LICENSE file. | 4 found in the LICENSE file. |
| 5 --> | 5 --> |
| 6 | 6 |
| 7 <!-- | 7 <!-- |
| 8 This file is a comprehensive list of Chrome user actions along with the owner | 8 This file is a comprehensive list of Chrome user actions along with the owner |
| 9 and description for each user action. | 9 and description for each user action. |
| 10 | 10 |
| (...skipping 1695 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 1706 <action name="BrowserPlugin.Guest.Terminate"> | 1706 <action name="BrowserPlugin.Guest.Terminate"> |
| 1707 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> | 1707 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> |
| 1708 <description>Please enter the description of this user action.</description> | 1708 <description>Please enter the description of this user action.</description> |
| 1709 </action> | 1709 </action> |
| 1710 | 1710 |
| 1711 <action name="BrowserPlugin.PermissionAllow.Download"> | 1711 <action name="BrowserPlugin.PermissionAllow.Download"> |
| 1712 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> | 1712 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> |
| 1713 <description>Please enter the description of this user action.</description> | 1713 <description>Please enter the description of this user action.</description> |
| 1714 </action> | 1714 </action> |
| 1715 | 1715 |
| 1716 <action name="BrowserPlugin.PermissionAllow.Geolocation"> | |
| 1717 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> | |
| 1718 <description>Please enter the description of this user action.</description> | |
| 1719 </action> | |
| 1720 | |
| 1721 <action name="BrowserPlugin.PermissionAllow.JSDialog"> | 1716 <action name="BrowserPlugin.PermissionAllow.JSDialog"> |
| 1722 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> | 1717 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> |
| 1723 <description>Please enter the description of this user action.</description> | 1718 <description>Please enter the description of this user action.</description> |
| 1724 </action> | 1719 </action> |
| 1725 | 1720 |
| 1726 <action name="BrowserPlugin.PermissionAllow.Media"> | 1721 <action name="BrowserPlugin.PermissionAllow.Media"> |
| 1727 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> | 1722 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> |
| 1728 <description>Please enter the description of this user action.</description> | 1723 <description>Please enter the description of this user action.</description> |
| 1729 </action> | 1724 </action> |
| 1730 | 1725 |
| 1731 <action name="BrowserPlugin.PermissionAllow.NewWindow"> | 1726 <action name="BrowserPlugin.PermissionAllow.NewWindow"> |
| 1732 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> | 1727 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> |
| 1733 <description>Please enter the description of this user action.</description> | 1728 <description>Please enter the description of this user action.</description> |
| 1734 </action> | 1729 </action> |
| 1735 | 1730 |
| 1736 <action name="BrowserPlugin.PermissionAllow.PointerLock"> | 1731 <action name="BrowserPlugin.PermissionAllow.PointerLock"> |
| 1737 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> | 1732 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> |
| 1738 <description>Please enter the description of this user action.</description> | 1733 <description>Please enter the description of this user action.</description> |
| 1739 </action> | 1734 </action> |
| 1740 | 1735 |
| 1741 <action name="BrowserPlugin.PermissionDeny.Download"> | 1736 <action name="BrowserPlugin.PermissionDeny.Download"> |
| 1742 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> | 1737 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> |
| 1743 <description>Please enter the description of this user action.</description> | 1738 <description>Please enter the description of this user action.</description> |
| 1744 </action> | 1739 </action> |
| 1745 | 1740 |
| 1746 <action name="BrowserPlugin.PermissionDeny.Geolocation"> | |
|
Alexei Svitkine (slow)
2014/04/14 20:36:30
Instead of removing these, please mark them as obs
| |
| 1747 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> | |
| 1748 <description>Please enter the description of this user action.</description> | |
| 1749 </action> | |
| 1750 | |
| 1751 <action name="BrowserPlugin.PermissionDeny.JSDialog"> | 1741 <action name="BrowserPlugin.PermissionDeny.JSDialog"> |
| 1752 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> | 1742 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> |
| 1753 <description>Please enter the description of this user action.</description> | 1743 <description>Please enter the description of this user action.</description> |
| 1754 </action> | 1744 </action> |
| 1755 | 1745 |
| 1756 <action name="BrowserPlugin.PermissionDeny.Media"> | 1746 <action name="BrowserPlugin.PermissionDeny.Media"> |
| 1757 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> | 1747 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> |
| 1758 <description>Please enter the description of this user action.</description> | 1748 <description>Please enter the description of this user action.</description> |
| 1759 </action> | 1749 </action> |
| 1760 | 1750 |
| (...skipping 8940 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 10701 <action name="WebView.Guest.PluginLoadRequest"> | 10691 <action name="WebView.Guest.PluginLoadRequest"> |
| 10702 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> | 10692 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> |
| 10703 <description>Please enter the description of this user action.</description> | 10693 <description>Please enter the description of this user action.</description> |
| 10704 </action> | 10694 </action> |
| 10705 | 10695 |
| 10706 <action name="WebView.Guest.Terminate"> | 10696 <action name="WebView.Guest.Terminate"> |
| 10707 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> | 10697 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> |
| 10708 <description>Please enter the description of this user action.</description> | 10698 <description>Please enter the description of this user action.</description> |
| 10709 </action> | 10699 </action> |
| 10710 | 10700 |
| 10701 <action name="WebView.PermissionAllow.Geolocation"> | |
| 10702 <owner>fsamuel@chromium.org</owner> | |
| 10703 <owner>lazyboy@chromium.org</owner> | |
| 10704 <description> | |
| 10705 Tracks when the geolocation permission is explicitly allowed on a webview. | |
| 10706 </description> | |
| 10707 </action> | |
| 10708 | |
| 10709 <action name="WebView.PermissionDeny.Geolocation"> | |
| 10710 <owner>fsamuel@chromium.org</owner> | |
| 10711 <owner>lazyboy@chromium.org</owner> | |
| 10712 <description> | |
| 10713 Tracks when the geolocation permission is explicitly denied on a webview. | |
| 10714 </description> | |
| 10715 </action> | |
| 10716 | |
| 10711 <action name="WebView.Reload"> | 10717 <action name="WebView.Reload"> |
| 10712 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> | 10718 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> |
| 10713 <description>Please enter the description of this user action.</description> | 10719 <description>Please enter the description of this user action.</description> |
| 10714 </action> | 10720 </action> |
| 10715 | 10721 |
| 10716 <action name="WebView.Stop"> | 10722 <action name="WebView.Stop"> |
| 10717 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> | 10723 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> |
| 10718 <description>Please enter the description of this user action.</description> | 10724 <description>Please enter the description of this user action.</description> |
| 10719 </action> | 10725 </action> |
| 10720 | 10726 |
| (...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 10857 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> | 10863 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> |
| 10858 <description>Please enter the description of this user action.</description> | 10864 <description>Please enter the description of this user action.</description> |
| 10859 </action> | 10865 </action> |
| 10860 | 10866 |
| 10861 <action name="webapps.AddShortcut.Bookmark"> | 10867 <action name="webapps.AddShortcut.Bookmark"> |
| 10862 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> | 10868 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> |
| 10863 <description>Please enter the description of this user action.</description> | 10869 <description>Please enter the description of this user action.</description> |
| 10864 </action> | 10870 </action> |
| 10865 | 10871 |
| 10866 </actions> | 10872 </actions> |
| OLD | NEW |
