Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2356263003: Revert of Remove console viewport test from expectations after fix (Closed)

Created:
4 years, 3 months ago by dewittj
Modified:
4 years, 3 months ago
Reviewers:
skobes, ymalik, lushnikov, luoe
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove console viewport test from expectations after fix (patchset #1 id:1 of https://codereview.chromium.org/2357783002/ ) Reason for revert: console-viewport-selection.html is still failing: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/70720 Original issue's description: > Remove console viewport test from expectations after fix > > When scroll anchoring was promoted to experimental status, it broke viewport > related LayoutTests, so expectations were updated for their failure. Now that > the tests have been fixed, the expectations need to be updated. > > Promotion CL: > https://codereview.chromium.org/2291653002 > > Tests fixed CL: > https://codereview.chromium.org/2317343006 > > BUG=624534 > > Committed: https://crrev.com/2d42a22c81372bb8f3ffb685ad6c66bcb205a3a5 > Cr-Commit-Position: refs/heads/master@{#420110} TBR=skobes@chromium.org,ymalik@chromium.org,lushnikov@chromium.org,luoe@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624534 Committed: https://crrev.com/0dc0f9e069272c917c85232446074b2719013377 Cr-Commit-Position: refs/heads/master@{#420134}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dewittj
Created Revert of Remove console viewport test from expectations after fix
4 years, 3 months ago (2016-09-21 19:24:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356263003/1
4 years, 3 months ago (2016-09-21 19:25:16 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 19:26:11 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 19:29:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0dc0f9e069272c917c85232446074b2719013377
Cr-Commit-Position: refs/heads/master@{#420134}

Powered by Google App Engine
This is Rietveld 408576698