Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: extensions/renderer/extensions_render_frame_observer.cc

Issue 2356253006: Make SplitStringUsingSubstr have consistent args. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/chrome_content_client_unittest.cc ('k') | net/ftp/ftp_directory_listing_parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/extensions_render_frame_observer.cc
diff --git a/extensions/renderer/extensions_render_frame_observer.cc b/extensions/renderer/extensions_render_frame_observer.cc
index 409980ae89ae8b800b0b6db853d1aa09445e082e..be6dbccd2f1e12e36e90bbc7021516595a1dbbec 100644
--- a/extensions/renderer/extensions_render_frame_observer.cc
+++ b/extensions/renderer/extensions_render_frame_observer.cc
@@ -40,15 +40,15 @@ StackTrace GetStackTraceFromMessage(base::string16* message,
if (message->find(base::UTF8ToUTF16(kStackFrameDelimiter)) !=
base::string16::npos) {
- base::SplitStringUsingSubstr(*message,
- base::UTF8ToUTF16(kStackFrameDelimiter),
- &pieces);
+ pieces = base::SplitStringUsingSubstr(
+ *message, base::UTF8ToUTF16(kStackFrameDelimiter),
+ base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
*message = pieces[0];
index = 1;
} else if (!stack_trace.empty()) {
- base::SplitStringUsingSubstr(stack_trace,
- base::UTF8ToUTF16(kStackFrameDelimiter),
- &pieces);
+ pieces = base::SplitStringUsingSubstr(
+ stack_trace, base::UTF8ToUTF16(kStackFrameDelimiter),
+ base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
}
// If we got a stack trace, parse each frame from the text.
« no previous file with comments | « chrome/common/chrome_content_client_unittest.cc ('k') | net/ftp/ftp_directory_listing_parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698