Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1691)

Unified Diff: chrome/browser/media/webrtc/webrtc_log_uploader_unittest.cc

Issue 2356253006: Make SplitStringUsingSubstr have consistent args. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/webrtc/webrtc_log_uploader_unittest.cc
diff --git a/chrome/browser/media/webrtc/webrtc_log_uploader_unittest.cc b/chrome/browser/media/webrtc/webrtc_log_uploader_unittest.cc
index 568d2470587f0ef88a5461a10dbc91672ad1b03d..164ecff2ed76fe6861ca697a1f5176e27e32794a 100644
--- a/chrome/browser/media/webrtc/webrtc_log_uploader_unittest.cc
+++ b/chrome/browser/media/webrtc/webrtc_log_uploader_unittest.cc
@@ -149,8 +149,8 @@ class WebRtcLogUploaderTest : public testing::Test {
void VerifyRtpDumpInMultipart(const std::string& post_data,
const std::string& dump_name,
const std::string& dump_content) {
- std::vector<std::string> lines;
- base::SplitStringUsingSubstr(post_data, "\r\n", &lines);
+ std::vector<std::string> lines = base::SplitStringUsingSubstr(
+ post_data, "\r\n", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
std::string name_line = "Content-Disposition: form-data; name=\"";
name_line.append(dump_name);

Powered by Google App Engine
This is Rietveld 408576698