Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: components/password_manager/core/browser/password_manager_client.h

Issue 235623002: Password manager internals page: Improve security (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: innerHTML -> innerText Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_client.h
diff --git a/components/password_manager/core/browser/password_manager_client.h b/components/password_manager/core/browser/password_manager_client.h
index f015e9d3a1f69de9950effbb9e8b7b4d0f7bdd07..d119089c7871405bf945b67291dd0d2efd749b9d 100644
--- a/components/password_manager/core/browser/password_manager_client.h
+++ b/components/password_manager/core/browser/password_manager_client.h
@@ -5,9 +5,12 @@
#ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_CLIENT_H_
#define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_CLIENT_H_
+#include <vector>
+
#include "base/metrics/field_trial.h"
#include "components/autofill/core/common/password_form.h"
#include "components/autofill/core/common/password_form_fill_data.h"
+#include "components/autofill/core/common/save_password_progress_logger.h"
class PrefService;
@@ -64,8 +67,9 @@ class PasswordManagerClient {
// Attach or detach (setting NULL) a logger for this client.
virtual void SetLogger(PasswordManagerLogger* logger) = 0;
- // Send |text| to the logger.
- virtual void LogSavePasswordProgress(const std::string& text) = 0;
+ // Sanitize |logs|, convert them to a string, and send them to the logger.
+ virtual void LogSavePasswordProgress(const std::vector<
+ autofill::SavePasswordProgressLogger::StructuredLog>& logs) = 0;
// Returns true if logs recorded via LogSavePasswordProgress will be
// displayed, and false otherwise.

Powered by Google App Engine
This is Rietveld 408576698