Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Unified Diff: components/password_manager/core/browser/browser_save_password_progress_logger_unittest.cc

Issue 235623002: Password manager internals page: Improve security (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: innerHTML -> innerText Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/browser_save_password_progress_logger_unittest.cc
diff --git a/components/password_manager/core/browser/browser_save_password_progress_logger_unittest.cc b/components/password_manager/core/browser/browser_save_password_progress_logger_unittest.cc
index ba056d2574f0027abbb37d8c36ee4bed01e82d58..7b308c3ae407aa8517c2b4dab6bac5991e41837a 100644
--- a/components/password_manager/core/browser/browser_save_password_progress_logger_unittest.cc
+++ b/components/password_manager/core/browser/browser_save_password_progress_logger_unittest.cc
@@ -8,12 +8,12 @@
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
+using autofill::SavePasswordProgressLogger;
+
namespace password_manager {
namespace {
-const char kTestText[] = "test";
-
// The only purpose of TestLogger is to expose SendLog for the test.
class TestLogger : public BrowserSavePasswordProgressLogger {
public:
@@ -25,7 +25,9 @@ class TestLogger : public BrowserSavePasswordProgressLogger {
class MockPasswordManagerClient : public StubPasswordManagerClient {
public:
- MOCK_METHOD1(LogSavePasswordProgress, void(const std::string& text));
+ MOCK_METHOD1(LogSavePasswordProgress,
+ void(const std::vector<
+ autofill::SavePasswordProgressLogger::StructuredLog>& logs));
};
} // namespace
@@ -33,8 +35,11 @@ class MockPasswordManagerClient : public StubPasswordManagerClient {
TEST(BrowserSavePasswordProgressLoggerTest, SendLog) {
MockPasswordManagerClient client;
TestLogger logger(&client);
- EXPECT_CALL(client, LogSavePasswordProgress(kTestText)).Times(1);
- logger.SendLog(kTestText);
+ std::vector<SavePasswordProgressLogger::StructuredLog> logs;
+ logs.push_back(SavePasswordProgressLogger::StructuredLog(
+ SavePasswordProgressLogger::STRING_MESSAGE));
+ EXPECT_CALL(client, LogSavePasswordProgress(logs)).Times(1);
+ logger.SendLog(logs);
}
} // namespace password_manager

Powered by Google App Engine
This is Rietveld 408576698