Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issue 2356213004: Adjust paint invalidation rects to match the actual radius of rastered blur. (Closed)

Created:
4 years, 3 months ago by chrishtr
Modified:
4 years, 3 months ago
Reviewers:
f(malita)
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust paint invalidation rects to match the actual radius of rastered blur. Skia actually renders to a larger radius than just blur(). BUG=648963, 624175 Committed: https://crrev.com/f48b1a4cf3a2181780d1326fb5ac53c7ace86551 Cr-Commit-Position: refs/heads/master@{#420570}

Patch Set 1 #

Patch Set 2 : none #

Patch Set 3 : none #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +27 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ShadowData.h View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 19 (13 generated)
chrishtr
4 years, 3 months ago (2016-09-22 21:19:42 UTC) #5
chrishtr
Planning to check if this is tested by existing tests.
4 years, 3 months ago (2016-09-22 21:20:13 UTC) #6
f(malita)
lgtm
4 years, 3 months ago (2016-09-22 21:27:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356213004/40001
4 years, 3 months ago (2016-09-23 00:13:36 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-23 03:52:20 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 03:56:01 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f48b1a4cf3a2181780d1326fb5ac53c7ace86551
Cr-Commit-Position: refs/heads/master@{#420570}

Powered by Google App Engine
This is Rietveld 408576698