Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2356163002: [stubs] Remove OnStackArgsDescriptor and friends. (Closed)

Created:
4 years, 3 months ago by Igor Sheludko
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Remove OnStackArgsDescriptor and friends. Each stub should have more meaningful descriptor instead. BUG=v8:5407 Committed: https://crrev.com/14a87d9639641ec2f0ff1cd9a3042551f48f9dc9 Cr-Commit-Position: refs/heads/master@{#39593}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -121 lines) Patch
M src/code-stubs.h View 3 chunks +2 lines, -8 lines 0 comments Download
M src/interface-descriptors.h View 7 chunks +27 lines, -80 lines 0 comments Download
M src/interface-descriptors.cc View 1 chunk +0 lines, -33 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
Igor Sheludko
PTAL
4 years, 3 months ago (2016-09-21 11:15:18 UTC) #4
Benedikt Meurer
lgtm
4 years, 3 months ago (2016-09-21 11:15:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356163002/1
4 years, 3 months ago (2016-09-21 11:21:48 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 11:50:58 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 11:51:37 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14a87d9639641ec2f0ff1cd9a3042551f48f9dc9
Cr-Commit-Position: refs/heads/master@{#39593}

Powered by Google App Engine
This is Rietveld 408576698