Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2352163004: [stubs] ApiCallbackDescriptor cleanup - make it independent on the number of JS parameters. (Closed)

Created:
4 years, 3 months ago by Igor Sheludko
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] ApiCallbackDescriptor cleanup - make it independent on the number of JS parameters. This cleanup is necessary to make HCallWithDescriptor support passing arguments on the stack. BUG=v8:5407 Committed: https://crrev.com/12d4dc32220aa1ed9593015a0b362376dd6eb50f Cr-Commit-Position: refs/heads/master@{#39590}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -153 lines) Patch
M src/arm/interface-descriptors-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/compiler/code-assembler.h View 1 chunk +6 lines, -1 line 0 comments Download
M src/compiler/code-assembler.cc View 5 chunks +7 lines, -17 lines 0 comments Download
M src/fast-accessor-assembler.cc View 1 chunk +25 lines, -17 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/interface-descriptors.h View 2 chunks +4 lines, -78 lines 0 comments Download
M src/interface-descriptors.cc View 1 chunk +2 lines, -27 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/s390/interface-descriptors-s390.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
Igor Sheludko
PTAL
4 years, 3 months ago (2016-09-21 10:30:30 UTC) #4
Benedikt Meurer
lgtm
4 years, 3 months ago (2016-09-21 10:40:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2352163004/1
4 years, 3 months ago (2016-09-21 11:04:50 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 11:08:29 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 11:08:53 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12d4dc32220aa1ed9593015a0b362376dd6eb50f
Cr-Commit-Position: refs/heads/master@{#39590}

Powered by Google App Engine
This is Rietveld 408576698