Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2356013002: Remove unused was_fetched_via_proxy members (Closed)

Created:
4 years, 3 months ago by Charlie Harrison
Modified:
4 years, 2 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, jam, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused was_fetched_via_proxy members Committed: https://crrev.com/49714cce0664eadd15a9de6291b3b01d127156b4 Cr-Commit-Position: refs/heads/master@{#422123}

Patch Set 1 #

Patch Set 2 : remove more members #

Patch Set 3 : remove even more! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -78 lines) Patch
M content/browser/loader/resource_loader.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M content/child/web_url_loader_impl.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M content/child/weburlresponse_extradata_impl.h View 1 2 2 chunks +0 lines, -20 lines 0 comments Download
M content/common/frame_messages.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M content/common/resource_messages.h View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/common/resource_response.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/common/resource_response_info.h View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M content/public/common/resource_response_info.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/public/renderer/document_state.h View 1 2 2 chunks +0 lines, -13 lines 0 comments Download
M content/public/renderer/document_state.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 2 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebURLResponse.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceResponse.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/public/platform/WebURLResponse.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 39 (23 generated)
Charlie Harrison
If this patch causes runtime errors I will be terrified. So far so good... Nasko, ...
4 years, 3 months ago (2016-09-20 22:55:13 UTC) #8
nasko
All unused code removal is LGTM in my book :). I'd suggest pinging bengr@ just ...
4 years, 2 months ago (2016-09-21 22:34:43 UTC) #11
Charlie Harrison
Thanks, +bengr in that case.
4 years, 2 months ago (2016-09-21 23:10:42 UTC) #13
tbansal1
drive-by-comment: Thanks a ton for doing this. DRP definitely does not need proxy server on ...
4 years, 2 months ago (2016-09-23 15:39:01 UTC) #15
Charlie Harrison
Thanks for the drive-by. Updated the CL per your request.
4 years, 2 months ago (2016-09-23 18:01:49 UTC) #20
tbansal1
On 2016/09/23 18:01:49, Charlie Harrison wrote: > Thanks for the drive-by. Updated the CL per ...
4 years, 2 months ago (2016-09-23 18:05:05 UTC) #21
bengr
lgtm
4 years, 2 months ago (2016-09-23 18:23:19 UTC) #22
Charlie Harrison
Thanks. +haraken for platform changes.
4 years, 2 months ago (2016-09-23 18:27:33 UTC) #24
Charlie Harrison
-haraken, +jochen for public and platform changes (simple).
4 years, 2 months ago (2016-09-23 18:28:39 UTC) #26
haraken
On 2016/09/23 18:28:39, Charlie Harrison wrote: > -haraken, +jochen for public and platform changes (simple). ...
4 years, 2 months ago (2016-09-24 00:46:44 UTC) #27
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2016-09-26 15:05:03 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356013002/40001
4 years, 2 months ago (2016-09-26 15:06:40 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/286132)
4 years, 2 months ago (2016-09-26 15:46:26 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356013002/40001
4 years, 2 months ago (2016-09-30 14:32:42 UTC) #36
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-30 15:49:26 UTC) #37
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 15:52:56 UTC) #39
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/49714cce0664eadd15a9de6291b3b01d127156b4
Cr-Commit-Position: refs/heads/master@{#422123}

Powered by Google App Engine
This is Rietveld 408576698