Thumb2 Backend: 16-bit instruction encoding helper methods

src/arm/assembler-arm-inl.h

Index: src/arm/assembler-arm-inl.h
diff --git a/src/arm/assembler-arm-inl.h b/src/arm/assembler-arm-inl.h
index a1d1e1b5670b57bc77a063c588748dd632dcb492..72e4ffaf8b6f0aa796d9de248171be437b0229d8 100644
--- a/src/arm/assembler-arm-inl.h
+++ b/src/arm/assembler-arm-inl.h
@@ -386,6 +386,15 @@ void Assembler::emit(Instr x) {
 }
 
 
+void Assembler::emit16(Instr16 x, bool check_buffer) {

[rmcilroy_google, 2013/09/17 17:28:16]

Why do you need the check_buffer parameter?  There don't seem to be any uses of
it in this CL.

[rkrithiv, 2013/09/27 21:40:49]

This is used in later patches.

On 2013/09/17 17:28:16, rmcilroy_google wrote:

[rmcilroy, 2013/10/01 10:26:04]

Please just do always do the CheckBuffer() here and re-introduce the boolean
argument in the CL when it is needed.

+  if (check_buffer) {
+    CheckBuffer();
+  }
+  *reinterpret_cast<Instr16*>(pc_) = x;
+  pc_ += 2;

[rmcilroy_google, 2013/09/17 17:28:16]

Please make this a constant (e.g., kThumb2InstrSize)

+}
+
+
 Address Assembler::target_pointer_address_at(Address pc) {
   Address target_pc = pc;
   Instr instr = Memory::int32_at(target_pc);