Thumb2 Backend: 16-bit instruction encoding helper methods

src/arm/assembler-arm-inl.h

 // Copyright (c) 1994-2006 Sun Microsystems Inc.
 // All Rights Reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions
 // are met:
 //
 // - Redistributions of source code must retain the above copyright notice,
 // this list of conditions and the following disclaimer.
 //
@@ skipping 368 matching lines @@
 }
 
 
 void Assembler::emit(Instr x) {
   CheckBuffer();
   *reinterpret_cast<Instr*>(pc_) = x;
   pc_ += kInstrSize;
 }
 
 
+void Assembler::emit16(Instr16 x, bool check_buffer) {

[rmcilroy_google, 2013/09/17 17:28:16]

Why do you need the check_buffer parameter?  There don't seem to be any uses of
it in this CL.

[rkrithiv, 2013/09/27 21:40:49]

This is used in later patches.

On 2013/09/17 17:28:16, rmcilroy_google wrote:

[rmcilroy, 2013/10/01 10:26:04]

Please just do always do the CheckBuffer() here and re-introduce the boolean
argument in the CL when it is needed.

+  if (check_buffer) {
+    CheckBuffer();
+  }
+  *reinterpret_cast<Instr16*>(pc_) = x;
+  pc_ += 2;

[rmcilroy_google, 2013/09/17 17:28:16]

Please make this a constant (e.g., kThumb2InstrSize)

+}
+
+
 Address Assembler::target_pointer_address_at(Address pc) {
   Address target_pc = pc;
   Instr instr = Memory::int32_at(target_pc);
   // If we have a bx instruction, the instruction before the bx is
   // what we need to patch.
   static const int32_t kBxInstMask = 0x0ffffff0;
   static const int32_t kBxInstPattern = 0x012fff10;
   if ((instr & kBxInstMask) == kBxInstPattern) {
     target_pc -= kInstrSize;
     instr = Memory::int32_at(target_pc);
@@ skipping 117 matching lines @@
 
 
 void Assembler::set_target_address_at(Address pc, Address target) {
   set_target_pointer_at(pc, target);
 }
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_ARM_ASSEMBLER_ARM_INL_H_