Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 2355923002: Revert of Clear stencil buffer before using it for drawing (Closed)

Created:
4 years, 3 months ago by stani
Modified:
4 years, 3 months ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Clear stencil buffer before using it for drawing (patchset #2 id:20001 of https://codereview.chromium.org/2342873004/ ) Reason for revert: performance regression in Android macrobench tests Original issue's description: > Clear stencil buffer before using it for drawing > > Clear stencil buffer before using it for drawing. This is > resolving an issue with a failing android CTS test in drawArc. > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342873004 > > Committed: https://skia.googlesource.com/skia/+/c326a383e1069497884905f9dd3e720e17d8fcb5 TBR=bsalomon@google.com,reed@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://skia.googlesource.com/skia/+/89e6af69b21fdcdb497d5f93c0a465634e18e055

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M src/gpu/GrGpu.cpp View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
stani
Created Revert of Clear stencil buffer before using it for drawing
4 years, 3 months ago (2016-09-20 18:56:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2355923002/1
4 years, 3 months ago (2016-09-20 18:56:16 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 20:24:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/89e6af69b21fdcdb497d5f93c0a465634e18e055

Powered by Google App Engine
This is Rietveld 408576698